From 1e67bff01ceb948a65d522eaf6b23c88711a5170 Mon Sep 17 00:00:00 2001 From: Anders Leino Date: Fri, 14 Aug 2026 10:45:27 +0300 Subject: [PATCH] Revert "Incorrect host access masks in pipeline barriers (#1097)" (#1121) This reverts commit 9482448393f3f1f75067cc6ba8ad77fda48691c6. The other way of resolving this is to add VK_PIPELINE_STAGE_HOST_BIT, which was done in the preceeding commit to this file (ab06e46eae47ac711762f8e2b951ea2d9837a01a). That is prefereable because callers of MemoryBarrier assume that it does host synchronization. --- src/vulkan/resource.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/vulkan/resource.cc b/src/vulkan/resource.cc index 4b488420..c3fd7f91 100644 --- a/src/vulkan/resource.cc +++ b/src/vulkan/resource.cc @@ -34,7 +34,8 @@ VkMemoryBarrier kMemoryBarrierForAll = { VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT | - VK_ACCESS_TRANSFER_READ_BIT | VK_ACCESS_TRANSFER_WRITE_BIT, + VK_ACCESS_TRANSFER_READ_BIT | VK_ACCESS_TRANSFER_WRITE_BIT | + VK_ACCESS_HOST_READ_BIT | VK_ACCESS_HOST_WRITE_BIT, VK_ACCESS_INDIRECT_COMMAND_READ_BIT | VK_ACCESS_INDEX_READ_BIT | VK_ACCESS_VERTEX_ATTRIBUTE_READ_BIT | VK_ACCESS_UNIFORM_READ_BIT | VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT | @@ -42,7 +43,8 @@ VkMemoryBarrier kMemoryBarrierForAll = { VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT | - VK_ACCESS_TRANSFER_READ_BIT | VK_ACCESS_TRANSFER_WRITE_BIT}; + VK_ACCESS_TRANSFER_READ_BIT | VK_ACCESS_TRANSFER_WRITE_BIT | + VK_ACCESS_HOST_READ_BIT | VK_ACCESS_HOST_WRITE_BIT}; } // namespace