Skip to content

Import Style Guide #109

Description

@zghera

Issue summary

Consistent import ... statements throughout the project.

Expected behavior

The general groupings should be:

import React ...
any other react specific imports (ex: react-router-dom)

React bootstrap, Firestore, other 3rd party imports

Local file imports

Within each of the sections, the order of the import "types" should be from least to most specific. Example:

import 'file.js';
import * as File from 'file.js';
import File from 'file.js';
import { Func } from 'file.js';

Actual behavior

Inconsistencies between (and potentially within) the user auth, activities, and trips sections of SLURP. First pointed out in PR #82 comments.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions