Restored from slopsmith/slopsmith-desktop#307 — original pull request (open PR; branch did not survive redaction, archived as issue), opened by @byrongamatos on 2026-06-10.
[restored-from: slopsmith/slopsmith-desktop#307]
Why
Follow-up to #306. ci.yml (PRs into release/**) and ship-ci.yml (PRs into main) carried an identical check job copy-pasted into both files — they'd inevitably drift (the npm-audit continue-on-error mismatch CodeRabbit flagged on #306 was exactly that class of bug). This mirrors the core repo's pattern (#779), where ship-ci reuses ci via workflow_call.
Change
ci.yml: add a workflow_call: trigger.ship-ci.yml: replace the duplicated check job with uses: ./.github/workflows/ci.yml.
Behaviour is unchanged — both paths still run checkout → typecheck → non-blocking npm audit. Net −20 lines.
Self-test
This PR targets main, so ship-ci.yml runs on it and exercises the new workflow_call reuse end-to-end.
Note: Codex preflight not run (Codex CLI usage-limited until tomorrow); manual + CodeRabbit review.
🤖 Generated with Claude Code
Summary by CodeRabbit
- Chores
- Consolidated CI quality check workflows to ensure consistent validation standards across all pull request scenarios, reducing maintenance overhead through centralized workflow configuration.
Why
Follow-up to #306.
ci.yml(PRs intorelease/**) andship-ci.yml(PRs intomain) carried an identical check job copy-pasted into both files — they'd inevitably drift (the npm-auditcontinue-on-errormismatch CodeRabbit flagged on #306 was exactly that class of bug). This mirrors the core repo's pattern (#779), whereship-cireusesciviaworkflow_call.Change
ci.yml: add aworkflow_call:trigger.ship-ci.yml: replace the duplicatedcheckjob withuses: ./.github/workflows/ci.yml.Behaviour is unchanged — both paths still run checkout → typecheck → non-blocking
npm audit. Net −20 lines.Self-test
This PR targets
main, soship-ci.ymlruns on it and exercises the newworkflow_callreuse end-to-end.🤖 Generated with Claude Code
Summary by CodeRabbit