feat(updater): remove duplicate Updates UI; now lives in slopsmith

[mogul]

Restored from slopsmith/slopsmith-desktop#214 — original pull request (open PR; branch did not survive redaction, archived as issue), opened by @byrongamatos on 2026-05-23.
[restored-from: slopsmith/slopsmith-desktop#214]

Summary

Follow-up to slopsmith #372 (merged 145a20a0b), which moved the Velopack auto-update controls into slopsmith's own Settings page as a top-level App Updates block.

The audio_engine plugin's settings panel — where the Updates UI was originally placed — would otherwise render a duplicate copy of the same controls once the desktop bundle picks up the new slopsmith static (bundle-slopsmith.sh clones slopsmith main HEAD). This PR removes that duplicate.

Removed

• src/renderer/settings.html: the #ae-updates-section card (channel dropdown, Check button, status line, Linux note).
• src/renderer/screen.js: setupUpdateChannelControls() + its call site in setupEvents(); the top-level restart-banner IIFE — both now live in slopsmith's static/app.js as setupAppUpdates() + initAppUpdateBanner().

Kept (unchanged)

• src/main/update-manager.ts, src/main/preload.ts, src/main/ipc-channels.ts — the Velopack IPC backend stays. slopsmith's bundled app.js consumes it via window.slopsmithDesktop.update.{getStatus,setChannel,checkNow,apply,onAvailable,onDownloaded}.

Test plan

• CI matrix (manually triggered — workflow_dispatch on a maintainer branch, per the existing fork-PR pattern).
• Run the built AppImage on Linux: the audio_engine plugin's settings panel no longer shows the Updates card; slopsmith's Settings page shows the top-level "App Updates" block (disabled, with the Linux fallback note).
• Verify on a Win/macOS build that "Check for updates" and the restart banner still function (driven by slopsmith's app.js now).

Codex preflight

Codex flagged 1 P1 claiming this removes the only renderer path that calls update:apply. Push-back: false positive — cross-repo blindness. The replacement renderer code lives in slopsmith #372 (already merged) and is pulled in via scripts/bundle-slopsmith.sh. The IPC backend is intentionally left intact for that reason.

🤖 Generated with Claude Code

[mogul]

[restored-pr-reviews: slopsmith/slopsmith-desktop#214]
Reconstructed from the backup. The PR's conversation-thread comments were not captured; reviews and inline review comments follow.

Reviews

@copilot-pull-request-reviewer[bot] — COMMENTED — 2026-05-23

Pull request overview

Removes the duplicate Velopack “Updates” UI from the desktop-bundled audio_engine settings panel now that update controls have moved into the main Slopsmith Settings page (bundled static assets), while keeping the existing desktop update IPC/backend intact.

Changes:

• Removed the Updates card from audio_engine’s settings HTML.
• Removed the corresponding renderer wiring in screen.js (channel/check UI + restart banner).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/renderer/settings.html	Removes the Updates section card to avoid duplicate update controls in the audio engine settings UI.
src/renderer/screen.js	Removes update-channel UI logic and the update-downloaded restart banner previously rendered by this plugin renderer.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Review comments

@Copilot on src/renderer/settings.html:2 — 2026-05-23

@@ -1,31 +1,4 @@
 <div class="space-y-3">
-    <div id="ae-updates-section" class="border border-slate-700 rounded-lg p-3 bg-slate-800/30">
-        <div class="text-xs font-semibold text-slate-300 mb-2">Updates</div>
-        <div class="grid grid-cols-1 md:grid-cols-2 gap-3">
-            <div>
-                <label class="block text-xs text-slate-400 mb-1" for="update-channel">Update channel</label>
-                <select id="update-channel" class="w-full bg-slate-700 border border-slate-
…(truncated)

PR description says bundle-slopsmith.sh clones slopsmith main HEAD, but this script only bundles an existing slopsmith checkout; the actual cloning is done by clone_slopsmith() in scripts/build-common.sh (CI/release builds) or via a developer-provided $SLOPSMITH_DIR/sibling checkout. Consider updating the PR description to reflect where the clone happens to avoid confusion when reproducing locally.

[mogul]

Superseded by reconstructed pull request #19 (original slopsmith/slopsmith-desktop#214).