Skip to content

Invalid value for varchar field when running ght-restore-pg #80

Description

@larsborn

Executing the ght-restore-pg on the data from 2018-09-01 gives the following error:

ERROR:  value too long for type character varying(356)
CONTEXT:  COPY commit_comments, line 2315625, column body: "@@ -0,0 +1,462 @@

this is due to the fact that the field body in commit_comments is specified as varying(356) in pg_schema.sql. I suggest changing the type to text.

To my knowledge this doesn't have any negative effect on space requirements and should even increase import performance since length of the data doesn't need to be checked. Should I submit a PR?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions