Skip to content

deprecation warning; !default should only be written once for each variable. #1155

Description

@EKoetsjarjan

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-widgets@5.8.4 for the project I'm working on.

I have got a deprecation warning

!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
   ╷
10 │ $box-shadow-up: 0 0.5em 1em rgba(#000, 0.175) !default !default;
   │                                                        ^^^^^^^^
   ╵

Here is the diff that solved the warning:

diff --git a/node_modules/react-widgets/scss/popup.scss b/node_modules/react-widgets/scss/popup.scss
index 3ddc5c5..9c812a7 100644
--- a/node_modules/react-widgets/scss/popup.scss
+++ b/node_modules/react-widgets/scss/popup.scss
@@ -7,7 +7,7 @@ $border: $widget-border-color !default;
 $border-radius: $widget-border-radius !default;
 $box-shadow-offset: 1em !default;
 $box-shadow: 0 0.5em 1em rgba(#000, 0.175) !default;
-$box-shadow-up: 0 0.5em 1em rgba(#000, 0.175) !default !default;
+$box-shadow-up: 0 0.5em 1em rgba(#000, 0.175) !default;
 
 $zindex: 1005 !default;
 $zindex-focused: $zindex + 1 !default;

This issue body was partially generated by patch-package.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions