Skip to content

Correct how docker registry credentials are passed or documented  #101

Description

@RickMoynihan

The docstring states credentials should be supplied like this:

Credentials
:from-registry - map of :username and :password to string, used for pulling from registry
:to-registry - map of :username and :password to string, used for uploading to registry

However the opts on that api function are just passed directly into the jib namespace; and that expects the keys to be formatted like they are here:

to-registry-username
to-registry-password

I'm happy to work up a patch for this; but it's unclear to me what the intention is.

A work around to pass to credentials is to just call api/docker with :to-registry-username and :to-registry-password set.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions