Skip to content

Race on rapid combobox open/close (org/repo data hooks) #181

Description

@ryota-murakami

Summary

useOrganizationData and useRepositoryData lack AbortController and a cancelled flag.

Source

P2 follow-up from /ship adversarial review of PR #176 (silent GitHub token refresh).

Details

Out-of-order resolution from rapid open→close→open can land stale data into the combobox state.

Fix

Add an ignore flag in the effect closure (or AbortController).

Acceptance

  • Rapid open/close does not show stale data
  • Tests cover the cancellation path

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2-mediumPlan for this monthbugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions