ci: use setup-msvc-dev action instead of a hard-coded vcvars path

The windows-cmake job set up the MSVC environment by calling a hard-coded
"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
in its NMake, clang-cl and Meson steps. The hosted windows-latest image no
longer has Visual Studio installed under that "Enterprise" path, so those steps
started failing with "The system cannot find the path specified."

Set up the developer environment once per job with the
TheMrMilchmann/setup-msvc-dev action -- it locates the installed toolchain (no
hard-coded path or edition) and exports the environment for the following steps
-- and drop all the hard-coded vcvars64.bat calls.

Because that environment now applies to the whole job, force gcc for the MinGW
configure steps; otherwise CMake's "MinGW Makefiles" generator picks up cl.

Assisted-by: claude-code:claude-opus-4-8

Author: Youw

.github/workflows/builds.yml

@@ -193,6 +193,10 @@ jobs:
         choco install ninja
         pip3 install meson
         refreshenv
+    - name: Set up MSVC developer environment
+      uses: TheMrMilchmann/setup-msvc-dev@v4
+      with:
+        arch: x64
     - name: Configure CMake MSVC
       shell: cmd
       run: |
@@ -235,13 +239,11 @@ jobs:
     - name: Configure CMake NMake MSVC
       shell: cmd
       run: |
-        call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
         cmake -G"NMake Makefiles" -B build\nmake -S hidapisrc -DCMAKE_BUILD_TYPE=RelWithDebInfo -DHIDAPI_WITH_TESTS=ON -DHIDAPI_BUILD_PP_DATA_DUMP=ON -DHIDAPI_ENABLE_ASAN=ON -DCMAKE_INSTALL_PREFIX=install\nmake -DHIDAPI_BUILD_HIDTEST=ON "-DCMAKE_C_FLAGS=%MSVC_COMPILE_FLAGS%"
     - name: Build CMake NMake MSVC
       working-directory: build\nmake
       shell: cmd
       run: |
-        call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
         nmake install
     - name: Check artifacts CMake NMake MSVC
       uses: andstor/file-existence-action@v2
@@ -254,7 +256,6 @@ jobs:
     - name: Check CMake NMake MSVC Export Package
       shell: cmd
       run: |
-        call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
         cmake ^
           -G"NMake Makefiles" ^
           -B build\nmake_test ^
@@ -271,13 +272,11 @@ jobs:
     - name: Configure CMake NMake ClangCL
       shell: cmd
       run: |
-        call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
         cmake -G"NMake Makefiles" -B build\clang_cl -S hidapisrc -D CMAKE_C_COMPILER=clang-cl -DCMAKE_BUILD_TYPE=RelWithDebInfo -DHIDAPI_WITH_TESTS=ON -DHIDAPI_BUILD_PP_DATA_DUMP=ON -DHIDAPI_ENABLE_ASAN=OFF -DCMAKE_INSTALL_PREFIX=install\clang_cl -DHIDAPI_BUILD_HIDTEST=ON "-DCMAKE_C_FLAGS=%MSVC_COMPILE_FLAGS%"
     - name: Build CMake NMake ClangCL
       working-directory: build\clang_cl
       shell: cmd
       run: |
-        call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
         nmake install
     - name: Check artifacts CMake NMake ClangCL
       uses: andstor/file-existence-action@v2
@@ -290,7 +289,6 @@ jobs:
     - name: Check CMake NMake ClangCL Export Package
       shell: cmd
       run: |
-        call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
         cmake ^
           -G"NMake Makefiles" ^
           -B build\clang_cl_test ^
@@ -306,10 +304,12 @@ jobs:
       working-directory: build/clang_cl
       run: ctest -C RelWithDebInfo --no-compress-output --output-on-failure
 
+    # MinGW must use gcc; the job-wide MSVC environment set up above would
+    # otherwise make CMake's "MinGW Makefiles" generator pick up cl.
     - name: Configure CMake MinGW
       shell: cmd
       run: |
-        cmake -G"MinGW Makefiles" -B build\mingw -S hidapisrc -DCMAKE_BUILD_TYPE=RelWithDebInfo -DHIDAPI_WITH_TESTS=ON -DHIDAPI_BUILD_PP_DATA_DUMP=ON -DCMAKE_INSTALL_PREFIX=install\mingw -DHIDAPI_BUILD_HIDTEST=ON "-DCMAKE_C_FLAGS=%GNU_COMPILE_FLAGS%"
+        cmake -G"MinGW Makefiles" -DCMAKE_C_COMPILER=gcc -B build\mingw -S hidapisrc -DCMAKE_BUILD_TYPE=RelWithDebInfo -DHIDAPI_WITH_TESTS=ON -DHIDAPI_BUILD_PP_DATA_DUMP=ON -DCMAKE_INSTALL_PREFIX=install\mingw -DHIDAPI_BUILD_HIDTEST=ON "-DCMAKE_C_FLAGS=%GNU_COMPILE_FLAGS%"
     - name: Build CMake MinGW
       working-directory: build\mingw
       run: cmake --build . --target install
@@ -326,6 +326,7 @@ jobs:
       run: |
         cmake ^
           -G"MinGW Makefiles" ^
+          -DCMAKE_C_COMPILER=gcc ^
           -B build\mingw_test ^
           -S hidapisrc\hidtest ^
           -Dhidapi_ROOT=install\mingw ^
@@ -340,7 +341,6 @@ jobs:
     - name: Check Meson build
       shell: cmd
       run: |
-        call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
         meson setup build_meson hidapisrc
         cd build_meson
         ninja