Skip to content
This repository was archived by the owner on Jun 4, 2026. It is now read-only.
This repository was archived by the owner on Jun 4, 2026. It is now read-only.

Fix remaining strict types errors #113

Description

@millnut

With Drupal core moving towards strict types, more info we should fix the remaining errors suppressed in the phpstan baseline.

 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_workflows/modules/localgov_workflows_notifications/src/Form/LocalgovServiceContactForm.php
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  74     Method Drupal\localgov_workflows_notifications\Form\LocalgovServiceContactForm::validateForm() should return Drupal\Core\Entity\ContentEntityInterface but return statement is missing.
  81     Method Drupal\localgov_workflows_notifications\Form\LocalgovServiceContactForm::validateForm() should return Drupal\Core\Entity\ContentEntityInterface but return statement is missing.
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_workflows/modules/localgov_workflows_notifications/src/WorkflowNotification.php
 ------ ----------------------------------------------------------------------------------------------------------
  62     Variable $queue_item might not be defined.
 ------ ----------------------------------------------------------------------------------------------------------

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions