get rid of replacement characters on output of MSVC compiler

[Luan Vitor Simião Oliveira (LuanVSO)]

if MSVC prints any warnings with non-ascii characters, replacement characters are printed.
how do i fix this?

[Colen Garoutte-Carson (Colengms)]

Hi Luan Vitor Simião Oliveira (@LuanVSO) . You might try asking about this in the VS Code repo: https://github.com/microsoft/vscode . If the same command line results in correct output in a normal command prompt window, this would seem to be an issue with VS Code's terminal. This issue would likely impact output from other command line tools as well.

[Luan Vitor Simião Oliveira (LuanVSO)]

Colen Garoutte-Carson (@Colengms) i don't think it is a vscode issue, because if i define an identical task but change the type from cppbuild to shell or process then it prints fine:

> Executing task: C/C++: cl.exe arquivo de build ativo <

Iniciando o build...
cl.exe /Zi /EHsc /nologo /Fe: C:\Users\luanv\Source\Repos\test\swap-generic.exe C:\Users\luanv\Source\Repos\test\swap-generic.c
swap-generic.c

C:\Users\luanv\Source\Repos\test\swap-generic.c(14): error C2057: esperada express�o constante

C:\Users\luanv\Source\Repos\test\swap-generic.c(14): error C2466: n�o � poss�vel alocar uma matriz de dimens�o constante 0
C:\Users\luanv\Source\Repos\test\swap-generic.c(14): error C2133: 'cpy': dimens�o desconhecida

Build concluído com êxito.

O terminal será reutilizado por tarefas, pressione qualquer tecla para fechá-lo.

> Executing task: C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.30.30705\bin\HostX64\x64\cl.exe /Zi /EHsc /nologo /Fe: c:\Users\luanv\Source\Repos\test\swap-generic.exe c:\Users\luanv\Source\Repos\test\swap-generic.c <

swap-generic.c
c:\Users\luanv\Source\Repos\test\swap-generic.c(14): error C2057: esperada expressão constante
c:\Users\luanv\Source\Repos\test\swap-generic.c(14): error C2466: não é possível alocar uma matriz de dimensão constante 0
c:\Users\luanv\Source\Repos\test\swap-generic.c(14): error C2133: 'cpy': dimensão desconhecida
O processo de terminal "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.30.30705\bin\HostX64\x64\cl.exe '/Zi', '/EHsc', '/nologo', '/Fe:', 'c:\Users\luanv\Source\Repos\test\swap-generic.exe', 'c:\Users\luanv\Source\Repos\test\swap-generic.c'" foi terminado com o código de saída: 2.

O terminal será reutilizado por tarefas, pressione qualquer tecla para fechá-lo.

> Executing task: cl.exe /Zi /EHsc /nologo /Fe: c:\Users\luanv\Source\Repos\test\swap-generic.exe c:\Users\luanv\Source\Repos\test\swap-generic.c <

swap-generic.c
c:\Users\luanv\Source\Repos\test\swap-generic.c(14): error C2057: esperada expressão constante
c:\Users\luanv\Source\Repos\test\swap-generic.c(14): error C2466: não é possível alocar uma matriz de dimensão constante 0
c:\Users\luanv\Source\Repos\test\swap-generic.c(14): error C2133: 'cpy': dimensão desconhecida
O processo de terminal "C:\Windows\system32\cmd.exe /d /c cl.exe /Zi /EHsc /nologo /Fe: c:\Users\luanv\Source\Repos\test\swap-generic.exe c:\Users\luanv\Source\Repos\test\swap-generic.c" foi terminado com o código de saída: 2.

O terminal será reutilizado por tarefas, pressione qualquer tecla para fechá-lo.

the task.json:

{
    "tasks": [
        {
           // only this one prints �
            "type": "cppbuild",
            "label": "C/C++: cl.exe arquivo de build ativo",
            "command": "cl.exe",
            "args": [
                "/Zi",
                "/EHsc",
                "/nologo",
                "/Fe:",
                "${fileDirname}\\${fileBasenameNoExtension}.exe",
                "${file}"
            ],
            "options": {
                "cwd": "${fileDirname}"
            },
            "problemMatcher": [
                "$msCompile"
            ],
            "group": {
                "kind": "build",
                "isDefault": true
            },
            "detail": "Tarefa gerada pelo Depurador."
        },
        {
            "type": "shell",
            "label": "type shell",
            "command": "cl.exe",
            "args": [
                "/Zi",
                "/EHsc",
                "/nologo",
                "/Fe:",
                "${fileDirname}\\${fileBasenameNoExtension}.exe",
                "${file}"
            ],
            "options": {
                "cwd": "${fileDirname}"
            },
            "problemMatcher": [
                "$msCompile"
            ],
        },
        {
            "type": "process",
            "label": "type process",
            "command": "cl.exe",
            "args": [
                "/Zi",
                "/EHsc",
                "/nologo",
                "/Fe:",
                "${fileDirname}\\${fileBasenameNoExtension}.exe",
                "${file}"
            ],
            "options": {
                "cwd": "${fileDirname}"
            },
            "problemMatcher": [
                "$msCompile"
            ],
        }
    ],
    "version": "2.0.0"
}

[Colen Garoutte-Carson (Colengms)]

Hi Luan Vitor Simião Oliveira (@LuanVSO) . You're right. This is an unusual case in which the C/C++ extension is invoking the command line directly and routing the resulting text to VS Code. I've confirmed the original output of the command is passed along to VS Code without modification, but it seems the API we are using assumes the text is in UTF-8 (and not using the same code page as the terminal), so non-ASCII characters are getting corrupted. VS Code handles the "shell" and "process" task types internally and doesn't appear to have that issue.

I've opened: #8518