From ba72e29bf5d7dc835fd015559e612b67a2e0c490 Mon Sep 17 00:00:00 2001 From: noursaidi Date: Sat, 24 Oct 2020 22:58:36 +0100 Subject: [PATCH] add result line for connection.network.mac_address --- docs/device_report.md | 12 +++++++++++- subset/network/run_macoui_test | 12 ++++++++++++ testing/test_aux.out | 3 +++ testing/test_aux.sh | 1 - 4 files changed, 26 insertions(+), 2 deletions(-) diff --git a/docs/device_report.md b/docs/device_report.md index 369af071b3..44dbb8d8dc 100644 --- a/docs/device_report.md +++ b/docs/device_report.md @@ -56,7 +56,7 @@ Overall device result FAIL |---|---|---|---|---|---| |Required|1|0|0|0|0| |Recommended|1|0|0|0|1| -|Other|6|2|21|1|2| +|Other|6|2|21|2|2| |Result|Test|Category|Expectation|Notes| |---|---|---|---|---| @@ -69,6 +69,7 @@ Overall device result FAIL |pass|communication.network.min_send|Other|Other|ARP packets received. Data packets were sent at a frequency of less than 5 minutes| |info|communication.network.type|Other|Other|Broadcast packets received. Unicast packets received.| |pass|connection.base.target_ping|Connectivity|Required|target reached| +|info|connection.network.mac_address|Other|Other|Device MAC address is 9a:02:57:1e:8f:01| |fail|connection.network.mac_oui|Other|Other|Manufacturer prefix not found!| |skip|connection.switch.port_duplex|Other|Other|No local IP has been set, check system config| |skip|connection.switch.port_link|Other|Other|No local IP has been set, check system config| @@ -599,6 +600,15 @@ Mac OUI Test -------------------- RESULT fail connection.network.mac_oui Manufacturer prefix not found! +-------------------- +connection.network.mac_address +-------------------- +Reports device MAC address +-------------------- +Device MAC address is 9a:02:57:1e:8f:01 +-------------------- +RESULT info connection.network.mac_address Device MAC address is 9a:02:57:1e:8f:01 + -------------------- dns.network.hostname_resolution -------------------- diff --git a/subset/network/run_macoui_test b/subset/network/run_macoui_test index 2507147b30..39a5d2880d 100755 --- a/subset/network/run_macoui_test +++ b/subset/network/run_macoui_test @@ -28,3 +28,15 @@ write_out_result $REPORT \ "$TEST_DESCRIPTION" \ "$TEST_RESULT" \ "$RESULT_AND_SUMMARY" + +# Write result for connection.network.mac_address +TEST_NAME="connection.network.mac_address" +TEST_DESCRIPTION="Reports device MAC address" +TEST_RESULT="Device MAC address is ${TARGET_MAC}" +RESULT_AND_SUMMARY="RESULT info ${TEST_NAME} ${TEST_RESULT}" + +write_out_result $REPORT \ + "$TEST_NAME" \ + "$TEST_DESCRIPTION" \ + "$TEST_RESULT" \ + "$RESULT_AND_SUMMARY" diff --git a/testing/test_aux.out b/testing/test_aux.out index b873ced907..a34f90be51 100644 --- a/testing/test_aux.out +++ b/testing/test_aux.out @@ -55,18 +55,21 @@ RESULT info communication.network.type Broadcast packets received. Unicast packe RESULT pass ntp.network.ntp_support Using NTPv4. RESULT pass ntp.network.ntp_update Device clock synchronized. RESULT fail connection.network.mac_oui Manufacturer prefix not found! +RESULT info connection.network.mac_address Device MAC address is 9a:02:57:1e:8f:01 RESULT skip dns.network.hostname_resolution Device did not send any DNS requests RESULT pass communication.network.min_send ARP packets received. Data packets were sent at a frequency of less than 5 minutes RESULT info communication.network.type Broadcast packets received. Unicast packets received. RESULT fail ntp.network.ntp_support Not using NTPv4. RESULT fail ntp.network.ntp_update Device clock not synchronized with local NTP server. RESULT pass connection.network.mac_oui Manufacturer: Google found for address 3c:5a:b4:1e:8f:0b +RESULT info connection.network.mac_address Device MAC address is 3c:5a:b4:1e:8f:0b RESULT fail dns.network.hostname_resolution Device sent DNS requests to servers other than the DHCP provided server RESULT pass communication.network.min_send ARP packets received. Data packets were sent at a frequency of less than 5 minutes RESULT info communication.network.type Broadcast packets received. Unicast packets received. RESULT skip ntp.network.ntp_support No NTP packets received. RESULT skip ntp.network.ntp_update Not enough NTP packets received. RESULT pass connection.network.mac_oui Manufacturer: Google found for address 3c:5a:b4:1e:8f:0a +RESULT info connection.network.mac_address Device MAC address is 3c:5a:b4:1e:8f:0a RESULT pass dns.network.hostname_resolution Device sends DNS requests and resolves host names dhcp requests 1 1 1 1 3c5ab41e8f0a: [] diff --git a/testing/test_aux.sh b/testing/test_aux.sh index ed6f03dc6f..ce2b250acf 100755 --- a/testing/test_aux.sh +++ b/testing/test_aux.sh @@ -114,7 +114,6 @@ done # Add the RESULT lines from all aux test report files. capture_test_results bacext -capture_test_results macoui capture_test_results tls capture_test_results password capture_test_results discover