The health_check_interval_min value (pkg/config/config.go:21) is passed straight to the WebSocket client (cmd/app.go:59). A zero or negative value is silently accepted and produces broken timer behavior at runtime.
Proposed scope
- In
config.Load, reject health_check_interval_min < 1 with a clear error, following the same pattern used for the required access_key / access_secret checks.
Acceptance criteria
- Unit test in
pkg/config/config_test.go covering negative, zero, and valid values.
- Error message is descriptive.
Pointers
pkg/config/config.go:21 (field), :88 (default), :135-140 (existing required-field error pattern)cmd/app.go:59 (consumer)
Good first issue: minimal, isolated validation.
The
health_check_interval_minvalue (pkg/config/config.go:21) is passed straight to the WebSocket client (cmd/app.go:59). A zero or negative value is silently accepted and produces broken timer behavior at runtime.Proposed scope
config.Load, rejecthealth_check_interval_min < 1with a clear error, following the same pattern used for the requiredaccess_key/access_secretchecks.Acceptance criteria
pkg/config/config_test.gocovering negative, zero, and valid values.Pointers
pkg/config/config.go:21(field),:88(default),:135-140(existing required-field error pattern)cmd/app.go:59(consumer)Good first issue: minimal, isolated validation.