test(plugin-approvals, plugin-security, service-messaging): run the companion step over the registered body instead of a second registry

Constructing a SchemaRegistry in a test makes check:registry-log-declared
require an OS_REGISTRY_LOG declaration in each package's vitest config,
outside this change's surface. The registry provisions the companion by
running `provisionSearchCompanion` over the body it has designated, so the
pin now runs that pure step over the engine's registered body, and asks
`resolveSearchCompanionSources` for the sources: none.

Claude-Session: https://claude.ai/code/session_01Evb5jFDZGKQE9KG4jbMfMF
Co-authored-by: Claude <noreply@anthropic.com>

Author: claude

packages/plugins/plugin-approvals/src/sys-approval-delegation-display-title.test.ts

@@ -30,7 +30,13 @@
  */
 
 import { describe, it, expect, beforeAll, afterAll } from 'vitest';
-import { ObjectQL, SchemaRegistry, SEARCH_COMPANION_FIELD, resolveRecordTitle } from '@objectstack/objectql';
+import {
+  ObjectQL,
+  SEARCH_COMPANION_FIELD,
+  provisionSearchCompanion,
+  resolveRecordTitle,
+  resolveSearchCompanionSources,
+} from '@objectstack/objectql';
 import { SqlDriver } from '@objectstack/driver-sql';
 import { resolveDisplayField } from '@objectstack/spec/data';
 import { SysApprovalDelegation } from './sys-approval-delegation.object.js';
@@ -148,13 +154,12 @@ describe('[#20044] sys_approval_delegation resolves a real record title under AD
   });
 
   it('provisions no search companion column, even where pinyin search is on', () => {
-    // The companion (`__search`) is a real column fed by the title field; a
-    // registry only provisions it when pinyin search is enabled, so ask one
-    // that is. A formula title is never a companion source.
-    const companionRegistry = new SchemaRegistry({ searchCompanion: true });
-    companionRegistry.registerObject(SysApprovalDelegation as any, 'com.objectstack.test.20044');
-    const registered = companionRegistry.getObject(OBJECT) as any;
-    expect(registered.nameField).toBe('display_title');
-    expect(registered.fields[SEARCH_COMPANION_FIELD]).toBeUndefined();
+    // The companion (`__search`) is a real column fed by the title field. A
+    // registry provisions it only where pinyin search is on, by running
+    // `provisionSearchCompanion` over the body it has just designated, so run
+    // that step over the registered body. A formula title is never a source.
+    const registered = engine.registry.getObject(OBJECT) as any;
+    expect(resolveSearchCompanionSources(registered)).toEqual([]);
+    expect(provisionSearchCompanion(registered).fields[SEARCH_COMPANION_FIELD]).toBeUndefined();
   });
 });

packages/plugins/plugin-security/src/objects/sys-security-assignment-display-title.test.ts

@@ -37,7 +37,13 @@
  */
 
 import { describe, it, expect, beforeAll, afterAll } from 'vitest';
-import { ObjectQL, SchemaRegistry, SEARCH_COMPANION_FIELD, resolveRecordTitle } from '@objectstack/objectql';
+import {
+  ObjectQL,
+  SEARCH_COMPANION_FIELD,
+  provisionSearchCompanion,
+  resolveRecordTitle,
+  resolveSearchCompanionSources,
+} from '@objectstack/objectql';
 import { SqlDriver } from '@objectstack/driver-sql';
 import { resolveDisplayField } from '@objectstack/spec/data';
 import { SysPositionPermissionSet } from './sys-position-permission-set.object.js';
@@ -187,14 +193,14 @@ describe('[#20044] permission-assignment tables resolve a real record title unde
     });
 
     it(`${object}: provisions no search companion column, even where pinyin search is on`, () => {
-      // The companion (`__search`) is a real column fed by the title field; a
-      // registry only provisions it when pinyin search is enabled, so ask one
-      // that is. A formula title is never a companion source.
-      const companionRegistry = new SchemaRegistry({ searchCompanion: true });
-      companionRegistry.registerObject(schema, 'com.objectstack.test.20044');
-      const registered = companionRegistry.getObject(object) as any;
-      expect(registered.nameField).toBe('display_title');
-      expect(registered.fields[SEARCH_COMPANION_FIELD]).toBeUndefined();
+      // The companion (`__search`) is a real column fed by the title field. A
+      // registry provisions it only where pinyin search is on, by running
+      // `provisionSearchCompanion` over the body it has just designated, so
+      // run that step over the registered body. A formula title is never a
+      // source.
+      const registered = engine.registry.getObject(object) as any;
+      expect(resolveSearchCompanionSources(registered)).toEqual([]);
+      expect(provisionSearchCompanion(registered).fields[SEARCH_COMPANION_FIELD]).toBeUndefined();
     });
   }
 });

packages/services/service-messaging/src/objects/notification-display-title.test.ts

@@ -37,7 +37,13 @@
  */
 
 import { describe, it, expect, beforeAll, afterAll } from 'vitest';
-import { ObjectQL, SchemaRegistry, SEARCH_COMPANION_FIELD, resolveRecordTitle } from '@objectstack/objectql';
+import {
+  ObjectQL,
+  SEARCH_COMPANION_FIELD,
+  provisionSearchCompanion,
+  resolveRecordTitle,
+  resolveSearchCompanionSources,
+} from '@objectstack/objectql';
 import { SqlDriver } from '@objectstack/driver-sql';
 import { resolveDisplayField } from '@objectstack/spec/data';
 import { NotificationDelivery } from './notification-delivery.object.js';
@@ -233,14 +239,13 @@ describe('[#20044] notification objects resolve a real record title under ADR-00
     });
 
     it(`${object}: provisions no search companion column, even where pinyin search is on`, () => {
-      // The companion (`__search`) is a real column fed by the title field; a
-      // registry only provisions it when pinyin search is enabled, so ask one
-      // that is.
-      const companionRegistry = new SchemaRegistry({ searchCompanion: true });
-      companionRegistry.registerObject(c.schema, 'com.objectstack.test.20044');
-      const registered = companionRegistry.getObject(object) as any;
-      expect(registered.nameField).toBe(c.pointer);
-      expect(registered.fields[SEARCH_COMPANION_FIELD]).toBeUndefined();
+      // The companion (`__search`) is a real column fed by the title field. A
+      // registry provisions it only where pinyin search is on, by running
+      // `provisionSearchCompanion` over the body it has just designated, so
+      // run that step over the registered body.
+      const registered = engine.registry.getObject(object) as any;
+      expect(resolveSearchCompanionSources(registered)).toEqual([]);
+      expect(provisionSearchCompanion(registered).fields[SEARCH_COMPANION_FIELD]).toBeUndefined();
     });
   }
 });