Skip to content

Commit 6c463ce

Browse files
committed
fix(lint): state the react-prop-deprecated warning's reason in words, not a tracker number
The react-prop-deprecated finding message ended by citing a tracker number that no longer resolves. It now says what that decision was: the react tier converges on the metadata-tier vocabulary, so the deprecated spelling keeps working through the deprecation window and is removed after it. The tag, prop and replacedBy interpolations are unchanged, as are the rule id, severity and hint. The sibling-package prose-id baseline shrinks by exactly that one pinned site, regenerated with the gate's own --census-ledger. Claude-Session: https://claude.ai/code/session_014EJ1ED8X4MMrT18BhVx4tx Co-authored-by: Claude <noreply@anthropic.com>
1 parent f29c83d commit 6c463ce

3 files changed

Lines changed: 15 additions & 2 deletions

File tree

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
---
2+
'@objectstack/lint': patch
3+
---
4+
5+
The `react-prop-deprecated` warning states its reason in words instead of citing a tracker number
6+
7+
The finding `validateReactPageProps` reports for a react-page prop written in a
8+
deprecated react-tier spelling used to end by pointing the author at an issue
9+
number that no longer resolves. It now says what that decision was, in the
10+
sentence being read: the react tier converges on the metadata-tier vocabulary,
11+
so the deprecated spelling keeps working through the deprecation window and is
12+
removed after it. The block tag, the prop and the canonical metadata-tier
13+
spelling it names are unchanged, and so are the rule id, the `warning`
14+
severity, the hint and every other finding.

‎packages/lint/src/validate-react-page-props.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1195,7 +1195,7 @@ export function validateReactPageProps(stack: AnyRec): ReactPropFinding[] {
11951195
severity: 'warning',
11961196
rule: REACT_PROP_DEPRECATED,
11971197
where, path,
1198-
message: `<${tag}> prop "${u}" is the deprecated spelling of the metadata-tier "${dep.replacedBy}" and is removed after the deprecation window (#11284).`,
1198+
message: `<${tag}> prop "${u}" is the deprecated spelling of the metadata-tier "${dep.replacedBy}": the react tier converges on the metadata-tier vocabulary, so this spelling keeps working through the deprecation window and is removed after it.`,
11991199
hint: dep.note,
12001200
});
12011201
}

‎scripts/doc-authoring-prose-id.baseline.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,6 @@
287287
"#7696": 1
288288
},
289289
"packages/lint/src/validate-react-page-props.ts": {
290-
"#11284": 1,
291290
"#5583": 1
292291
},
293292
"packages/lint/src/validate-readonly-flow-writes.ts": {

0 commit comments

Comments
 (0)