Skip to content

Three comments still point at metadata/src/utils/schema-sync-errors.ts after #13279 moved it to @objectstack/types #13516

Description

@claude

Found while implementing #13279's option-A relocation (PR #13475); out of that card's scope, filed unassigned for triage.

What moved

PR #13475 moves the driver-error classifier out of @objectstack/metadata and into @objectstack/types, under the maintainer's 2026-08-30 ruling:

packages/metadata/src/utils/schema-sync-errors.ts       -> packages/types/src/driver-error-classification.ts
packages/metadata/src/utils/schema-sync-errors.test.ts  -> packages/types/src/driver-error-classification.test.ts

@objectstack/metadata/errors still re-exports isMissingTableError, so no import breaks. The published surface is intact and nothing here is a functional defect.

The residual: three prose pointers now name a path that does not exist

Three comments in two packages reference the old location by path or by filename. Measured on PR #13475's head 5c7c0b66b9 with git grep schema-sync-errors:

file line what it says
packages/drivers/driver-sql/src/sql-driver.ts 816 names the pins as schema-sync-errors.test.ts
packages/drivers/driver-sql/src/sql-driver-backend-fault-envelope.test.ts 77 same reference, same wording
packages/services/service-analytics/src/analytics-service.ts 194 "same shape as metadata/src/utils/schema-sync-errors.ts"

Each is a reader's trail to the reasoning behind a driver-error verdict, so a dangling one costs the next author the thing the comment exists to give them.

Why PR #13475 did NOT fix them in place

The bounded in-place exemption needs the repair to add no new validation surface. These three sit in driver-sql and service-analytics, neither of which is otherwise in that PR's diff, so editing them would pull two more packages into its gate family for a comment change. The two pointers inside packages already in the diff WERE updated there (packages/types/src/unique-violation.ts, packages/types/src/error-leak.test.ts, and packages/services/service-datasource/src/external-datasource-service.ts), so this card is the declared remainder rather than the whole set.

Severity

Low. No behaviour, no published surface, no test. It is documentation drift created by a deliberate move, recorded so it does not become the kind of stale pointer nobody can date.

Suggested repair

Repoint all three at packages/types/src/driver-error-classification.ts (and .test.ts), keeping the historical note that it was metadata/src/utils/schema-sync-errors.ts before #13279 — the same wording PR #13475 used for the pointers it did update.


Generated by Claude Code

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions