You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found while implementing #13250 (the two remaining tolerant reference_to readers). Filed unassigned, out of scope for that card's PR — #13250's table named three readers and this is not one of them.
What is there
packages/objectql/src/master-detail.ts:58
const raw = def?.reference ?? def?.referenceTo;
with the tolerance declared in the type just above it:
/** Canonical reference target. `referenceTo` is the stored-row spelling. */
reference?: string;
referenceTo?: string;
This is a fourth live reader accepting a spelling FieldSchema rejects, after the three #13250 enumerated. It reads referenceTo only, not the snake_case reference_to.
Why this is an observation rather than a defect claim
Unlike the three on #13250, this one is not silent about being tolerant — it declares the alias in its own interface and states a population for it: "referenceTo is the stored-row spelling." That is exactly the shape the maintainer ruling on #13250 blessed for the security reader, so the tolerance may well be correct here too.
What is missing is the measurement behind the claim. The comment asserts that stored rows spell it referenceTo, and nothing in the tree measures whether that is still true, or how many such rows exist. So the question for triage is narrow:
Is the asserted stored-row population real and non-empty today?
⚠️ Before narrowing, check the failure mode the way #13250 had to: what does this resolver returning null cost its callers? If any of them fail closed, narrowing is an availability question and not a spelling question, and the answer is a migration first.
Related
#13250 (the three readers and the split ruling) · #13541 (the two dispositions landing) · #11567 (reference is the only spelling the spec declares)
Found while implementing #13250 (the two remaining tolerant
reference_toreaders). Filed unassigned, out of scope for that card's PR — #13250's table named three readers and this is not one of them.What is there
packages/objectql/src/master-detail.ts:58with the tolerance declared in the type just above it:
This is a fourth live reader accepting a spelling
FieldSchemarejects, after the three #13250 enumerated. It readsreferenceToonly, not the snake_casereference_to.Why this is an observation rather than a defect claim
Unlike the three on #13250, this one is not silent about being tolerant — it declares the alias in its own interface and states a population for it: "
referenceTois the stored-row spelling." That is exactly the shape the maintainer ruling on #13250 blessed for the security reader, so the tolerance may well be correct here too.What is missing is the measurement behind the claim. The comment asserts that stored rows spell it
referenceTo, and nothing in the tree measures whether that is still true, or how many such rows exist. So the question for triage is narrow:reference_to, notreference#11567 closed elsewhere, and it narrows to canonical-only.Related
#13250 (the three readers and the split ruling) · #13541 (the two dispositions landing) · #11567 (
referenceis the only spelling the spec declares)Generated by Claude Code