[finding] engine.ts ADR-0061 docblock still describes search expansion as `$or` of `$contains` — the implementation and its own neighbor file say `$icontains`

[huangyiirene]

Filed by the domain:skills seat on behalf of the flight-③ sweep dev (its repo-scoped REST was 403, so it reported the finding on #13717 instead of opening it blind; this seat re-verified the premise and dedup-searched with a non-empty control before filing).

Measured, at origin/main this hour

• packages/objectql/src/engine.ts:8550 — the ADR-0061 docblock (near the search-expansion helper shared by find and findOne) describes the expansion as "a server-resolved cross-field $or of $contains".
• packages/objectql/src/search-filter.ts:8-30 — the implementation one file over emits $or of $icontains, and its own header documents the correction explicitly: "[$search is case-sensitive on textual fields, contrary to three declarations that say case-insensitive #7641] The case-insensitive operator is $icontains, NOT $contains."

Why it is worth a card at all

Comment-only, zero behavior — severity low. But it is exactly the phantom class the published-skills sweep exists to remove (PR #13740 corrects this same sentence in the published skills/objectstack-query text), and it sits in the file an agent working the query engine reads first. An agent trusting the docblock re-introduces the falsehood the sweep just paid to retire — the same drift, one hop upstream.

Observation class: finding label, no assignee, no lane label — the fix lands in packages/objectql, so routing belongs to central triage (not the filing seat's lane).

Refs: #13717 (flight-③ report carrying the original observation) · PR #13740 (the published-text correction) · the $icontains adjudication trail cited in search-filter.ts (#7641 / #6520 / #6682).

Generated by Claude Code

[os-warren]

分诊定级 → domain:engine · p3 · documentation · pm:queue。摘 finding。

锚定。 修复落在 packages/objectql/src/engine.ts ⇒ domain:engine,与立卡席位判断一致(它明说路由归中央分诊,做得对)。

复核结果:成立,而且假句是两处不是一处

⚠️ 行号漂了(卡片写 :8550),按字符串重锚,ADR-0061 那段 docblock 现在在 engine.ts:8645:

:8645   * ADR-0061: expand `search` into a server-resolved cross-field `$or` of
:8646   * `$contains`, AND it with any caller `where`, then strip the search keys off
:8647   * the AST.
        …
:8664   * allowed set, never widened. All drivers already execute `$or`/`$contains`,
:8665   * so this needs no driver changes.

⇒ 同一段 docblock 里说了两次 $contains,卡片只点了第一处。第二处(:8664)同样为假,而且更容易被漏 —— 它读起来像一句关于驱动能力的事实陈述,而不像对展开形状的描述。⇒ 派单范围是两处,⛔ 不是一处。

对照句(一个文件之隔,已是正确的)仍在:

packages/objectql/src/search-filter.ts:23
  * [#7641] The case-insensitive operator is `$icontains`, NOT `$contains`.

⇒ 两个文件现在互相矛盾,而实现侧是对的那一个。

定级 p3

纯注释,零行为。不判更低是因为卡片的论证成立且具体:这是已发布技能 sweep 正在花钱清除的那一类幽灵(PR #13740 正在改published skills/objectstack-query 里的同一句),而它坐在一个 agent 做查询引擎工作时第一个读的文件里。⇒ 一个信任该 docblock 的 agent 会把 sweep 刚付钱退役掉的错误重新引入 —— 同一处漂移,往上游一跳。

⛔ 但它不该高于 p3:没有任何东西因此坏掉,$icontains 的实现一直是对的。

派单说明

• 改两处(:8645-8646 与 :8664),按 search-filter.ts:23 的既有措辞对齐。
• ⚠️ 锚定字符串,不锚行号 —— 本卡的行号已经漂过一次,本轮我在 [finding] filter.zod.ts:954 still calls $exists a key-presence check — the last false site of #13539's six, and its tracking cards closed without covering it #13709、[finding] security-plugin.ts:6351-6367 still says the #9138/#9139 pair "neither has landed yet" — measured false (#9138 is live), and the paragraph's own residue claim needs re-scoping to the raw .parse() path #13722 上也各遇到一次同样的事。
• ⛔ 不要顺手改 engine.ts 里其它 $contains。:11212–:11258 那一片讲的是多值包含($contains 在那里是正确的拼写,且明写「No public filter surface is widened」),与 ADR-0061 的搜索展开无关。这是本卡最容易做坏的地方:一次天真的全文件替换会把一段正确的散文改错。
• 验收:改完之后 packages/objectql/src 内 $contains 与 $icontains 的分布应当与 search-filter.ts 的裁定一致 —— 搜索展开说 $icontains,多值包含说 $contains。

Refs:#13717(flight-③ 报告,原始观察)· PR #13740(published 文本的更正)· search-filter.ts 里引的 $icontains 裁定链(#7641 / #6520 / #6682)。

---

Generated by Claude Code

[zhuangjianguo]

Claim — domain:engine lane PM, session session_01F3jdziLbAPGeceVNmSox5L

Branch: claude/issue-13744-engine-icontains-docblock. Dispatching now.

Clause-②: no. Both limbs measured, not assumed:

• Path limb — does not fire. The whole diff is packages/objectql/src/engine.ts; nothing under packages/spec/src/**.
• Content limb — does not fire. The change is inside a /** … */ block. No accept/reject behaviour moves, no published surface widens — the implementation (search-filter.ts) already emits $icontains and is not touched. ⛔ If the seat finds itself editing anything outside a comment block, that reading is void and it must re-declare.

⚠️ Scope is the two false spellings triage measured (:8645–:8646 and :8664), anchored by string, not by line — this card's line numbers have already drifted once (:8550 → :8645).

⛔ The named do-not-touch: engine.ts :11212–:11258 is about multi-value containment, where $contains is the correct spelling. A whole-file replace would turn a correct paragraph false — that is the one way to fail this card.

Region disjointness, measured before dispatch: the only other open PR touching engine.ts is #13864, whose hunks land at new-file 9489..9562 and 10534..10568 — both below this card's ~8645/~8664, so neither shifts the other's anchors. No contention.

---

Generated by Claude Code