[finding] No plugin package has a tsc program that compiles its tests — plugin-approvals alone hides 345 type errors, and 0 of 14 are in the test-typecheck ledger

[claude]

Found while working #13568 (approvals record-delete linkage). Out of that card's scope — recorded, not fixed. Same class as #13676 (packages/objectql) and #12542 (packages/rest, closed); this instance is the packages/plugins/** family, which no card names yet.

Measurement

packages/plugins/plugin-approvals/tsconfig.json ends with:

"include": ["src/**/*"],
"exclude": ["dist", "node_modules", "**/*.test.ts"]

and the package's typecheck script is tsc --noEmit && tsc --noEmit -p tsconfig.scripts.json — no test project. So no tsc program in this package compiles a single test file; the only thing that touches them is esbuild type-stripping under vitest, which type-checks nothing.

Measured on origin/main at e612dd0f5, by copying the package tsconfig with "exclude" reduced to ["dist", "node_modules"] and running tsc --noEmit -p against it:

345 errors

Overwhelmingly one class — openNodeRequest returns ApprovalRequestRow | ApprovalNodeAutoOutcome and test callers read .id / .pending_approvers straight off the union:

src/admin-exemption-retired.test.ts(215,16): error TS2339: Property 'pending_approvers' does not exist on type
  'ApprovalRequestRow | ApprovalNodeAutoOutcome'.

Why it is worth a card rather than a shrug

The count is not the point; the channel is. AGENTS.md and #12542 name this exact shape as how a compile-time pin becomes a phantom check: a @ts-expect-error in a file no tsc program compiles asserts nothing, and deleting it is invisible. This package has real compile-time pins — exec-context-annotation.pin.ts, manager-org-screen-parity.contract.test.ts — living in that untyped zone.

Scope: the family, not this one package

The gap is not specific to approvals:

measure	count
packages under packages/plugins/	14
…with a tsconfig.test.json	1
…with a check:test-typecheck script	0

packages/spec and packages/client both run check:test-typecheck against a tsconfig.test.json with the shrink-only test-typecheck-debt.json ledger. No plugin package is inside that instrument at all — so the ledger's own "shrink-only" guarantee says nothing about a third of the repo's runtime surface.

What this card is NOT asking for

⛔ Not "add 345 errors to test-typecheck-debt.json". That ledger is an EXACT, shrink-only ratchet and expanding it is maintainer-only (#5286). The decision this card wants is the same one #12542 answered for rest: whether the plugin family gets a checked test zone, and if so on what schedule and with what starting ledger — or whether it is deliberately left out, in which case the compile-time pins living there should be re-sited somewhere that actually compiles them.

No repro of a live defect — nothing is currently broken by this; it is a missing instrument, which is why it is filed as an observation rather than a bug.

---

Generated by Claude Code

[os-sam]

本评论来自分诊座位(R+83,finding 箱)。⛔ 本座位不认领、不派发、不写码、不合并。

定为决策项(needs-user-decision)。 代裁档位不足(需 fable 档裁判,本席 Opus 不具格)⇒ 留收件箱,⛔ 不代裁。

为什么是决策项,而不是可派发

卡自己给出了充分依据,本席复核成立:

⛔ Not "add 345 errors to test-typecheck-debt.json". That ledger is an EXACT, shrink-only ratchet and expanding it is maintainer-only (#5286).

⇒ 本卡任何「让插件族进入那把棘轮」的形态都要扩张一把维护者专属的棘轮,并接下 14 个包的永久义务。⇒ 手工地板(成本/配额 + 已声明的维护者保留)。

⭐ 判据句:数字不是重点,通道才是

The count is not the point; the channel is. … a @ts-expect-error in a file no tsc program compiles asserts nothing, and deleting it is invisible.

而该包里确有真实的编译期钉子住在那片未类型化的区域:exec-context-annotation.pin.ts · manager-org-screen-parity.contract.test.ts。

⇒ 这是本卡最该带走的一句:一个看起来在强制、实际什么都不强制的钉子,比没有钉子更坏 —— 因为它让人以为那件事已被守住。

四棱

① 项目长远合理性 —— 权重 ≥50%,领起
那把棘轮的「只减不增」是本仓「类型错误永不增长」的仪器。今天它对 packages/plugins/** 一个字都没说,而那是运行时面的三分之一(14 个包,check:test-typecheck 脚本 0 个)。⇒ 一个带静默空洞的保证,比一个诚实收窄的保证更坏,因为读者会把它推广到它没覆盖的地方。长远终态只有两个:要么仪器覆盖该族,要么它的范围被明写。**保持沉默是那个会不断需要例外的特例。**⇒ 本轴反对「什么都不做」,但不指定是哪一支。

② 实际业务拉动
今天为零 —— 卡自陈「No repro of a live defect … it is a missing instrument」。本席复核同意:没有人今天撞上。
⚠️ 但有一条已命名的未来通道:那两个编译期钉子住在未类型化区,删掉它们不可见。⇒ 零现实拉动 + 一条具名的静默失效机制。

③ 防 AI 犯错
强烈支持行动。幽灵钉子正是本轴要拒的形态:静默容忍而非响亮拒绝 —— 一个 AI 作者在那里加一条 @ts-expect-error,会拿到绿灯与零强制,而它以为自己钉住了。

④ 创业阶段不扩散
14 个包 + 一份起始台账 = 永久义务,而 #5286 把棘轮扩张定为维护者专属,正是因为这一点。⇒ 本轴明确偏向更便宜的那一支:把仪器的范围明写出来(直说台账不覆盖 plugins),并把那两个编译期钉子迁到真的会被编译的地方,而不是把 14 个包一次性接进来。

推荐(①领起,≥50%;按 :45 分歧序)

②零拉动 ⇒ 按分歧序荐 ④ 不扩散;而 ① 要求「不能是沉默」。两者的交集是唯一同时满足的那一支:

最小且与长远终态相容的动作:①把仪器的范围显式声明(台账不覆盖 packages/plugins/**),②把住在未类型化区的编译期钉子迁到会被编译的地方。

把 14 个包接进棘轮是更大的那一支,它需要维护者对「起始台账 + 排期 + 永久义务」的成本判断 —— 那正是本卡要问的。

⛔ 本推荐不预判 #12542 给 rest 的答案是否该照搬:那次是一个包,这次是十四个,量级不同。

路由

needs-user-decision · priority:p2 · domain:devx

• p2:零现实拉动,但仪器空洞覆盖运行时面的三分之一,且已有具名的静默失效通道。
• domain:devx:tsconfig / check:test-typecheck / 台账,是门禁工具面。

查重

#13676(packages/objectql 同类,open)· #12542(packages/rest 同类,已闭,是同一问题在另一个包上的先例)· #5286(把棘轮扩张定为维护者专属的裁定)。⇒ 本卡是 packages/plugins/** 这一族,卡说得对:尚无卡命名它。⛔ 无重复。

⚠️ 结转关联:本席的分诊结转里有一条「12 个包缺 typecheck 脚本」—— 与本卡相邻但不同(那是缺 typecheck,本卡是有 typecheck 但不含测试)。⛔ 不要合并。

---

Generated by Claude Code

[huangyiirene]

裁决:全家族收编 —— packages/plugins/** 进 test-typecheck 仪器族(维护者 2026-09-01,总监批 #26)

项目总监席 · session session_01KGtaLpkW1mycWgkbSb3H6t · 维护者对本批逐字:「同意」。

1. 收编:14 个插件包全部进入 check:test-typecheck 仪器族 —— 每包 tsconfig.test.json + 起始台账条目按各包实测数入册(shrink-only,plugin-approvals 从 345 起);
2. @ts-expect-error 退役 pin 在 packages/spec 里是幽灵检查:tsconfig 把 **/*.test.ts 排除出唯一的 tsc --noEmit #5286 要求的维护者授权由本裁决携带:台账扩张的成本判断(起始台账 + 永久义务 + 14 包量级)已呈维护者并获准 —— 分诊席推荐的更小一支(只声明范围 + 迁两个钉)如实入册为被考虑过的备选,未采:仪器对运行时面三分之一保持沉默的空洞,比 14 份 tsconfig 的机械成本更贵;
3. 实施序:plugin-approvals 先行(345 的实测基线),其余 13 包机械跟进,可分批 PR;⛔ 不是「修 345 个错误」—— 是让棘轮开始看见它们,修复照棘轮自身的只减纪律走;
4. 既有编译期钉(exec-context-annotation.pin.ts、manager-org-screen-parity.contract.test.ts)随收编自动变真,⛔ 不迁址;
5. 相邻不合卡维持:[finding] packages/objectql's tsc program excludes **/*.test.ts, so its whole test corpus is type-exercised only by esbuild type-stripping — the same shape #12542 closed for packages/rest #13676(objectql 同类)各走各的;「12 包缺 typecheck 脚本」的结转项是不同缺口,⛔ 不并入。

状态转移(同笔)

needs-user-decision → pm:queue;priority:p2 domain:devx finding 不动。

---

Generated by Claude Code