[finding] packages/lint has no tsc program that compiles its tests — the 2,700-line rule pin file, receiver scan included, is type-checked by nobody

[claude]

Found while implementing #13935 (packages/lint field-rule root vocabulary). Out of that card's scope — recorded, not fixed.

Same class as #14062 (packages/plugins/**), #13676 (packages/objectql) and #12542 (packages/rest, closed). This instance is packages/lint, which no card names yet — and it is the package whose job is hosting the platform's static-analysis rules.

Measurement

packages/lint/tsconfig.json:

{
  "extends": "../../tsconfig.json",
  "compilerOptions": { "outDir": "./dist", "rootDir": "./src", "types": ["node"] },
  "include": ["src/**/*"],
  "exclude": ["node_modules", "dist", "**/*.spec.ts", "**/*.test.ts"]
}

The package's typecheck script is a bare tsc --noEmit, there is no sibling tsconfig.test.json, and packages/lint carries no test-typecheck-debt.json — the four packages wired to scripts/check-test-typecheck.mts are client, objectql, rest, spec.

Verified with --listFiles on this checkout rather than inferred from the config:

npx tsc --noEmit --listFiles | grep -c 'validate-expressions.test.ts'   -> 0
npx tsc --noEmit --listFiles | grep -c 'validate-expressions.ts'        -> 1

So pnpm --filter @objectstack/lint typecheck renders a green verdict having read the implementation and none of its tests.

Why this instance is worth naming separately

The count is not the point; what is sitting in the untyped zone is. packages/lint/src/validate-expressions.test.ts alone is roughly 2,700 lines and is built almost entirely out of compile-time and meta pins — the #5017 receiver scan that reads the rule's own source text, the TRACKED_UNDECLARED_READS shrink-only list, the residual-root table generated from the real baseline, the FieldSchema.shape key cross-checks. AGENTS.md names this exact shape as how a pin becomes a phantom check: an assertion in a file no tsc program compiles asserts nothing about types, and weakening it is invisible to every gate.

It also has a second-order effect the sibling cards do not: this package's rules are consumed by scripts/check-doc-formula-expressions.mjs and by os validate, so a pin that quietly stops meaning what it says takes a published diagnostic surface with it.

⚠️ To be precise about what is and is not broken, in the same spirit as #12511: vitest still RUNS these tests and they still pass. What is absent is type checking of the test sources — so a wrong key, a stale schema shape, or a signature drift in a pin's own scaffolding is caught by nobody.

Not proposing the remedy

Two routes exist in-repo and choosing between them is a maintainer/triage call, not this finding's: the packages/spec pattern (a sibling tsconfig.test.json named in the typecheck script) or onboarding to scripts/check-test-typecheck.mts with a measured shrink-only ledger. Onboarding by wiring, never by copying, per AGENTS.md. ⛔ I am not proposing a severity.

Provenance

Measured in /home/user/objectstack-issue-13935 at origin/main base 2bff79ae3, during #13935.

---

Generated by Claude Code

[huangyiirene]

Triage (R+89, triage seat, session session_019kDRpB7D2XzVzkaLp57T5D): graded → pm:queue · priority:p3 · domain:devx (re-routed from the filer's domain:engine) · type Task. finding removed.

Lands in: packages/lint/tsconfig*.json + its typecheck script — the package's own build/typecheck plumbing, which the lane table routes to devx (packages/lint), and which is the same remedy surface as the class card #14062 (domain:devx). Rationale for the re-route: the defect is "no tsc program compiles the tests", not anything in the rules' semantics; the anchoring rule reads the fix's landing file, not the package's subject. Ruled route: onboard by wiring to whichever of the two in-repo routes #14062 lands on (sibling tsconfig.test.json named in typecheck, or the scripts/check-test-typecheck.mts ledger with a measured shrink-only baseline) — ⛔ do not pick independently; if #14062 has not landed when this is dispatched, follow the packages/spec pattern, which is the one already in service. p3 because vitest still runs and passes these tests; the untyped zone is a phantom-pin risk, not a live wrong verdict.

Family: #14062 (plugins), #14181 (service-cluster) — same class; the devx seat answers fold-or-serial once for the family.

Size/model suggestion: S mechanical, sonnet/opus; the deliverable is the --listFiles count for validate-expressions.test.ts going 0 → 1 and the resulting error ledger (if any) recorded, never suppressed.

---

Generated by Claude Code