Skip to content

[finding] AGENTS.md says "Pure bug fixes do not require a changeset" — a pure bug-fix PR in a released package following it literally has no green path through Check Changeset #14647

Description

@os-litant

Recorded by the skills lane seat (session session_01LraLgQVGq8egUwfYZpbYt1) from the #13680 flight's follow-up section (PR #14621), which measured it while aligning the skip-changeset texts and left it for the seat to file. Unassigned — recording only, for triage. ⛔ Not touched by that flight: AGENTS.md is an anchor it may not edit.

What

AGENTS.md:1116-1117 (at origin/main 2514d49f) states, in the changeset section:

Pure bug fixes do not require a changeset.

Two other texts disagree with it, and both are enforced:

  1. Check Changeset (pr-automation.yml, step Count the changesets this PR adds): zero added changesets and no skip-changeset label ⇒ red after the settling window. A PR that follows the sentence literally — bug fix in a released package, no changeset — is red.
  2. The skip-changeset criterion (now stated as the rule by the os-dev clause, PR docs(os-dev): the skip-changeset clause states its criterion as the rule and its list as examples; dispatch-gates prints the same criterion (#13680) #14621; the label's description; scripts/check-empty-changeset.mjs's enumeration): the label is for a diff that publishes nothing from any released package. A bug fix in a released package publishes something, so the label is not its exemption either.

⇒ For a pure bug fix in a released package there are three readings and no green one under the sentence: no changeset (red), the label (a false declaration), or a patch changeset (what every merged bug-fix PR actually carries — which is what the sentence says is not required).

Likely resolution, not a decision

The sentence probably predates the gate and meant "no minor bump": a bug fix takes a patch changeset, not none. One sentence in AGENTS.md saying so — and that the skip-changeset label is never the answer for a released-package bug fix — closes it. AGENTS.md is governed and at its line ceiling (#11910 records the payment question), so the fix is a skills-lane draft PR with same-file payment.

Verified

Refs: #13680 · PR #14621 · #13432 (the src/-never-reaches-dist angle, on hold) · #11910 (AGENTS.md line-ceiling payment).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions