Skip to content

[finding] the relative is SHADOWED comment in dispatch-gates selfTest goes stale once the node:path namespace import lands — it points a future editor at the one spelling that still does not work #14991

Description

@claude

Filed by the os-dev flight on #14688 (PR #14988), which removes the condition this comment describes. ⛔ Unassigned, ⛔ not graded, ⛔ no pm:queue — observation class.

What

scripts/pm/dispatch-gates.mjs carries a five-line comment inside selfTest(), immediately above the tierOwnAbs / tierOwnRel pair, explaining why the repo-relative spelling is taken from ROOT instead of by calling the node:path function:

// `relative` from `node:path` is SHADOWED inside this function — a fixture
// string a few thousand lines up binds that name — so the repo-relative
// spelling comes from ROOT, the prefix every sibling case here already joins
// against. A prefix that stops holding yields an empty root, which the walk
// above reports rather than turning into a pass.

Once PR #14988 lands, the first sentence is no longer true. That PR replaces the five bare node:path named imports with one namespace binding, so no module-scope relative binding exists to be shadowed. The fixture const relative = [...] stays exactly where it is, but it now shadows nothing.

Why it is a finding, not a card

The code is unaffected in both directions. The ROOT-derived spelling remains correct and remains the right thing to do — it is the prefix every sibling case in that block already joins against, so it is the consistent spelling rather than a workaround now. Only the stated REASON goes stale.

The cost is contributor-time and it is the specific kind this file is careful about: a reader who takes the comment at face value learns a fact about the module's imports that is false, and the natural repair — "then let me just call relative here" — is the one spelling that still does not work, because the fixture is still a string. So the stale comment points a future editor at a dead end.

This is a fresh instance of a class this file has closed before: #13536 was the same shape, a self-describing docblock in this file whose measured number had drifted from the live one.

Shape of a fix, not prescribed

Re-word the comment to state the standing reason (ROOT is the prefix the sibling cases join against) and drop the shadowing claim, or delete it and let the surrounding block speak. Either way it is prose on governed surface: draft PR, in-seat review.

⛔ Deliberately NOT folded into PR #14988. That PR is fenced by its triage ruling to a binding-name change with the battery's verdicts identical before and after; authoring new prose on governed surface is a judgment act outside that fence.

Blocked-by: PR #14988 — until that merges, the comment is accurate and there is nothing here to change.

Refs: #14688 · PR #14988 · #13536 (same class, closed)


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions