Skip to content

[finding] Two more source comments name out-of-repo app paths as live — objectql/src/plugin.ts:142 and cloud-connection/.../marketplace-install-local-seed-replayer.test.ts:16, both missed by #14806's census #15297

Description

@os-litant

Found while implementing #14806 (dev seat, session session_01D47qPfEWVPmhguWgBZCi5N, branch claude/issue-14806-out-of-repo-app-path-comments). Filed unassigned for triage. Deliberately NOT swept by that branch — both sites are outside the file surface that branch declared before editing, and one is in another package family, so editing them would have made a declared claim untrue while another lane was reading it.

The class, already established

A source comment naming a repository path is a checkable claim. apps/objectos and apps/cloud were deleted from this repo and now live in objectstack-ai/cloud. #14634 fixed three such sites, #14806 fixed six more. These two are the same defect and were in neither census.

Positive control, because the claim is a negative — apps/ is not empty and the query is not broken:

$ git ls-tree origin/main -- apps/
040000 tree f281e0156f1e4569560b79b9899d3ea56cfb7f1d	apps/docs

Site 1 — packages/objectql/src/plugin.ts:142

TSDoc on the skipSchemaSync option. Present tense, unmarked:

  /**
   * Skip both `syncRegisteredSchemas()` calls inside `start()` and
   * assume DDL is managed out-of-band (e.g. an `apps/cloud/scripts/migrate.ts`
   * run before deploy that connects directly to the database and creates
   * all `sys_*` + custom tables once).

⭐ This is the same sentence, about the same script, as packages/cli/src/commands/serve.ts's migrate-and-exit note — which #14806's branch has just fixed. They were written as a pair and drifted apart because only one of them was ever in a census. The referent is genuine, so the disposition is to mark it out-of-repo, not to rename or delete it.

Site 2 — packages/cloud-connection/src/marketplace-install-local-seed-replayer.test.ts:16

// A runtime that declares no data of its own — `objects: []`, no `data`, which is
// exactly what a marketplace-install target looks like and exactly what
// `apps/objectos-ee` is — therefore ended up with `seed-datasets` POPULATED and
// `seed-replayer` ABSENT.

Weaker than site 1 — it is a test's rationale, not an instruction — but it is the only apps/objectos-ee mention in the tree that does not mark the app as living elsewhere. Its three siblings all do: service-cluster/src/multi-node-gate-mount.ts:9 ("cloud repo"), service-cluster/src/multi-node-gate.test.ts:227 ("cloud: …"), packages/types/src/node.ts:72 ("Measured on cloud's …"). Consistency is the whole value here.

The spelling to copy — do not invent a fourth one

Take it from the branch above, so the sweep ends with one house style rather than four. serve.ts's migrate-and-exit note now reads:

      // Out-of-band migration mode: the caller (e.g.
      // `apps/cloud/scripts/migrate.ts`, which lives in the separate
      // `objectstack-ai/cloud` repo and is NOT a path in this one) just
      // wants the kernel bootstrap (ObjectQLPlugin → schema sync →

The oldest in-repo precedent is multi-node-gate-mount.ts:9's terse "(apps/objectos-ee/objectstack.config.ts, cloud repo)". Either is fine; a third is not.

The trap, unchanged and still the whole risk

⛔ Grep for the paths apps/objectos and apps/cloud. ⛔ Never for the bare tokens objectos or cloudobjectos.ai, cloud.objectos.ai, DEFAULT_CLOUD_URL, the root-domain guard, admin@objectos.ai as the dev seed address and the plugin ids objectos-ee / objectos-runtime / objectos-environment / objectos-stack are all correct, several matched as literal plugin ids inside serve.ts. A token sweep breaks working code.

⛔ Do not add an apps/objectos or apps/cloud directory to this repo to satisfy any comment.

Explicitly NOT in this card

Refs: #14806, #14634, #15295.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions