Skip to content

formula: 15 of its test-typecheck ledger errors have one cause — no @types/node and no types entry for a test layer that imports node:fs / node:path / node:url #16297

Description

@claude

Origin: filed by the domain:devx execution seat (#6023, session session_01Vbw3RPgdtqesx4azk9SbW8, 2026-09-06T12:44Z) from the #12511 dev's open question (PR #16295 report). Unlabelled for domain on purpose — packages/formula is the domain:engine lane's per the domain table; routing is triage's.

What

PR #16295 (Part of #12511) puts @objectstack/formula's 29 test files in front of tsc through a sibling tsconfig.test.json and records the residue in packages/formula/test-typecheck-debt.json (15 errors, 5 files, 12 signatures — down from the 17 TEST_DEBT recorded; the −2 are TS1470 dissolving under module: esnext). The dev's measurement: those 15 have a single cause — the package declares no @types/node devDependency and its tsconfig names no types, while two tests import node:fs / node:path / node:url and read import.meta.url.

Executable criterion

Add @types/node as a devDependency of packages/formula and "types": ["node"] to the test program (or the build config if that is where the sibling inherits types from — read the sibling's header first), then regenerate the ledger with pnpm --filter @objectstack/formula gen:test-typecheck-debt and show the shrink: the ledger's error count goes from 15 towards zero with no test file edited, and check:type-check-coverage --re-measure stays green. ⛔ Not a rider on #12511: that card's ruling is explicit that nothing is repaired in the onboarding PR.

Refs #12511 · PR #16295.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions