fix(ci): Unblock CI after the throttling and UI rework

Two issues surfaced in CI for the previous three commits:
- test_app_model_label.py instantiates VibeApp via SimpleNamespace
  stubs and now needs the new _effective_active_model helper bound on
  the stub via MethodType, so the test exercises the real resolver
  rather than failing on AttributeError.
- ruff flagged a tuple-membership check (PLR6201) in record_rate_limit
  and reformatted four files for trailing-comma and import-ordering
  conventions enforced by the pre-commit hook.

No behaviour change.

Author: obook

albert_code/cli/textual_ui/app.py

@@ -1930,9 +1930,7 @@ def _refresh_quota_display(self) -> None:
             if previous != effective.name:
                 self._last_displayed_model_name = effective.name
                 if previous is not None:
-                    self.run_worker(
-                        self._poll_daily_usage_once(), exclusive=False
-                    )
+                    self.run_worker(self._poll_daily_usage_once(), exclusive=False)
         except Exception:
             widget.clear()
 

albert_code/core/llm/quota.py

@@ -73,7 +73,8 @@ def midnight_utc_timestamp() -> int:
     import datetime as dt
 
     return int(
-        dt.datetime.now(dt.UTC)
+        dt.datetime
+        .now(dt.UTC)
         .replace(hour=0, minute=0, second=0, microsecond=0)
         .timestamp()
     )
@@ -115,10 +116,7 @@ async def fetch_albert_usage(
         async with httpx.AsyncClient(timeout=httpx.Timeout(timeout)) as client:
             offset = 0
             for _ in range(_USAGE_MAX_PAGES):
-                params: dict[str, int] = {
-                    "limit": _USAGE_PAGE_LIMIT,
-                    "offset": offset,
-                }
+                params: dict[str, int] = {"limit": _USAGE_PAGE_LIMIT, "offset": offset}
                 if since_timestamp is not None:
                     params["start_time"] = since_timestamp
                 response = await client.get(url, headers=headers, params=params)

albert_code/core/llm/throttling.py

@@ -331,7 +331,7 @@ def record_rate_limit(
             self._blocked_until = max(
                 self._blocked_until, self._clock() + retry_after_seconds
             )
-        if limit_type in ("tpm", "rpm"):
+        if limit_type in {"tpm", "rpm"}:
             self._saturate_window(limit_type, model_alias)
         if model_alias is None:
             return

tests/cli/textual_ui/test_app_model_label.py

@@ -12,7 +12,7 @@
 
 from __future__ import annotations
 
-from types import SimpleNamespace
+from types import MethodType, SimpleNamespace
 from typing import cast
 
 from albert_code.cli.textual_ui.app import VibeApp
@@ -34,7 +34,11 @@ def _make_stub(
         get_active_model=lambda: next(m for m in models if m.alias == active_alias),
     )
     agent_loop = SimpleNamespace(_last_resolved_model_alias=last_resolved)
-    return cast(VibeApp, SimpleNamespace(config=config, agent_loop=agent_loop))
+    stub = SimpleNamespace(config=config, agent_loop=agent_loop)
+    # Bind the real helper so the test exercises actual resolution logic
+    # rather than a duplicate. _format_model_label delegates to it.
+    stub._effective_active_model = MethodType(VibeApp._effective_active_model, stub)
+    return cast(VibeApp, stub)
 
 
 class TestFormatModelLabelPrimary:
@@ -115,7 +119,8 @@ def _raise() -> ModelConfig:
             active_model="ghost-model", models=[], get_active_model=_raise
         )
         agent_loop = SimpleNamespace(_last_resolved_model_alias=None)
-        stub = cast(VibeApp, SimpleNamespace(config=config, agent_loop=agent_loop))
+        stub = SimpleNamespace(config=config, agent_loop=agent_loop)
+        stub._effective_active_model = MethodType(VibeApp._effective_active_model, stub)
 
-        label = VibeApp._format_model_label(stub)
+        label = VibeApp._format_model_label(cast(VibeApp, stub))
         assert label == "⚙  ghost-model"

tests/core/test_quota.py

@@ -79,7 +79,7 @@ def test_account_info_accepts_router_id_alias() -> None:
         "limits": [
             {"router_id": 342, "type": "rpm", "value": 500},
             {"router_id": 342, "type": "tpm", "value": None},
-        ],
+        ]
     })
     assert len(info.limits) == 2
     assert info.limits[0].router == 342
@@ -280,4 +280,3 @@ async def test_fetch_albert_usage_returns_none_on_http_error(
         return_value=httpx.Response(500, json={"detail": "boom"})
     )
     assert await fetch_albert_usage(_make_provider()) is None
-