A links search with no matches says "No links yet"

[DennisAlund]

Found while reviewing #48. Pre-existing, not caused by that PR.

The links route sets links to the search results (src/index.tsx:230), so the empty-state branch at src/pages/links.tsx:221 cannot tell an empty catalog from an empty result set.

Reproduction

Catalog holds 200 links. Search for zzz.

• links.length === 0, so the branch falls to t("links.empty"): No links yet. Use the + New Link button above to get started.
• The user reads that their catalog is empty when it holds 200 links.

Fix

Add a third empty-state branch keyed on searchQuery, with copy naming the query that matched nothing. Keys go in src/i18n/en.ts, id.ts, and sv.ts.

[DennisAlund]

Partially fixed already, and PR #55 finishes it.

Already fixed. The symptom in the title, a search rendering No links yet. Use the + New Link button above to get started. over a populated catalog, is gone on main. Commit 4e5c81f ("Give the links empty state a third case and honest copy"), in #50, replaced the links.length > 0 branch at the old src/pages/links.tsx:221 with a three-value emptyReason the service computes, so an empty search result resolves to no-matches instead of falling through to the first-run copy. #50 was scoped to SQL-windowing the listing and never referenced this issue, which is why it stayed open. src/__tests__/page/links-page.test.ts:651 covers that path.

Not fixed. The Fix section of this report asks for a branch keyed on searchQuery with copy naming the query. That never landed. no-matches covers two different claims, a filter chip that selected none of the catalog and a search that matched none of it, and both rendered No links match the current filter. Searching zzz blamed a filter the user never touched and never said which query came back empty.

PR #55 adds links.noSearchMatches to en.ts, id.ts and sv.ts and splits the case in the page, so the copy reads No links match "zzz". Leaving this issue open until that merges.