Skip to content

Annotation over websites where text selection pop-ups exist is not working #124

Description

@haritzmedina

Problem

Sites where on text selection displays a popup, sometimes annotation is not created due to a lack of text focus and getSelection() returns empty.

How to reproduce

Go to sciencedirect (e.g.: WACline paper), open an annotation tool (like Highlight&Go) and select a small portion of text. A popup will be prompted. Then, try to annotate (using the sidebar) the selected fragment. It won't annotate anything.

image

How to solve

Should be check how the selection of text is done, and if whether exist a way to prevent lose focus when clicking outside of the created popup on the website. Possible solution to this issue should be addressed here:

if (document.getSelection().toString().length > 0) {

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions