Bad translate for some drc files

[goroka]

It omits the translate for Y and Z coordinates.

The bug is in Unsafe.toFloatArray() — loop condition i < ret.length should be d <
ret.length (line 159). i increments by 4 (byte offset) while ret.length is the
float count (e.g. 3 for XYZ), so only the first component gets the quantization
offset applied.

// Bug (line 159):
for (int i = 0, d = 0; i < ret.length; i += 4, d++)
// Fix:
for (int i = 0, d = 0; d < ret.length; i += 4, d++)

[javagl]

This issue could be seen as a duplicate, because it describes what was mentioned as the last remaining point in another issue: The bug was already fixed, but then the fix was overwritten with some auto-generated code.

However, given that the other issue described multiple things that had been wrong, it could make sense to keep track of this last one - the wrong loop condition - in this, dedicated issue. (The other one could then probably be closed, but I'll leave that to the maintainers, depending on their timeline for a fix in the upstream repository).

[lexchou-aspose]

Sorry for the late response, I have fixed this in C# source code and rerun the porter tool. Would you want me to deploy to maven?

[javagl]

I think that this bugfix could be a "low-hanging fruit", insofar that it is definitely a bug, affects many possible users, and it has an easy and straightforward fix (and it would close two issues here now 🙂 ). So I think that it could be worth a Maven release.

(I do not "need" this release immediately, but it would be nice to have, sooner or later, for javagl/JglTF#81 . In that context, I'll also use this library more extensively for writing draco data, and it's not unlikely that this will reveal further issues, but we could cross that bridge when we come to it)