From 7d6090185c61d5f1816bf97a8242450b721dba17 Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Fri, 26 Jun 2026 15:22:18 -0700 Subject: [PATCH] AGENTS: Drop 'Deploying CVO with Lightspeed Proposals' section We grew this recently in b0e4c90a3d (pkg/readiness: Add readiness checks and wire into proposal controller, 2026-05-27, #1395). But I don't think we need it. > The proposal controller is gated behind `TechPreviewNoUpgrade`. To > test on a Default feature set cluster... But folks can test on a tech-preview cluster, and I don't see a need to have folks edit and recompile the cluster-version operator to test on Default-feature-set clusters, when we have official docs on how to set your non-production cluster TechPreviewNoUpgrade [1]. > Build and push the skills image... But we have official build of the skills image by both ART and CI: $ oc -n ocp get -o json imagestream 5.0-art-latest | jq -r '.status.tags[] | select(.tag == "agentic-skills").items[] | .created + " " + .image' 2026-06-19T02:09:51Z sha256:3df589bb38baa9ba5ee08e48707585b7a9a90c8e37958c761420804284034d57 2026-06-17T23:09:07Z sha256:c0a98a27549db71c5fc319eadbabe0549f9f467cef0eadec683999685cd30b8f 2026-06-15T21:27:00Z sha256:c69acc6ee37d2e1b898bc0ef9999412837e2234b6bae30ad0e6e3ef2f35e3091 $ oc -n ocp get -o json imagestream 5.0 | jq -r '.status.tags[] | select(.tag == "agentic-skills").items[] | .created + " " + .image' 2026-06-10T17:53:31Z sha256:0c07886422894f138c40de3f9b85e76d374781f5ed0883d738466ecc41874de8 2026-06-02T13:28:31Z sha256:fad8159b2909f408837e9de2388cc5b946dca97a191dde44fae14694ee23b6ea 2026-05-28T20:13:04Z sha256:f683f957e7bfaa37578462f16932fbf67846b6e8b1b6f25841b539738a72fc62 and we'll soon be wiring those up to be included in the OpenShift release payload. Which will mean that folks who want to excercise custom skills image content will get that on presubmits in https://github.com/openshift/agentic-skills pulls, and Cluster Bot can generate new payloads which combine open agentic-skills pull requests with other open pull requests, and all the usual things. > Apply the prompt ConfigMap... When enabled (e.g. in a TechPreviewNoUpgrade standalone cluster), the cluster-version operator will apply the cluster-update-advisory-prompt ConfigMap (and the other manifests associated with this functionality) automatically. There's no need for users to manually apply those manifests. [1]: https://docs.redhat.com/en/documentation/openshift_container_platform/4.22/html/postinstallation_configuration/post-install-cluster-tasks#post-install-tp-tasks --- AGENTS.md | 42 ------------------------------------------ 1 file changed, 42 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 3f2fb85980..ce74c14f9f 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -189,45 +189,3 @@ Subsystems include: `pkg/cvo`, `pkg/payload`, `lib/resourceapply`, `hack`, etc. ### Development and Testing - Never test against production clusters - always use disposable test environments - CVO has significant control over cluster state and can disrupt operations during development - -### Deploying CVO with Lightspeed Proposals (Dev) - -The proposal controller is gated behind `TechPreviewNoUpgrade`. To test on a Default feature set cluster: - -1. **Bypass the feature gate** (local only, do not commit): - ```go - // In pkg/cvo/cvo.go, shouldEnableProposalController() - return true - ``` - -2. **Build and push the skills image** to the cluster's internal registry: - ```bash - oc new-project cvo-dev - # Build from the agentic-skills repo - podman build -f Dockerfile -t /cvo-dev/agentic-skills:latest . - podman push --tls-verify=false /cvo-dev/agentic-skills:latest - ``` - -3. **Set `LIGHTSPEED_SKILLS_IMAGE`** in `install/0000_00_cluster-version-operator_30_deployment.yaml` to the internal registry image (local only, do not commit): - ```yaml - - name: LIGHTSPEED_SKILLS_IMAGE - value: "image-registry.openshift-image-registry.svc:5000/cvo-dev/agentic-skills@sha256:..." - ``` - -4. **Build and deploy** following the standard dev workflow in `docs/dev/README.md`: - ```bash - CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o _output/linux/amd64/cluster-version-operator ./cmd/cluster-version-operator/ - # Build image on cluster, then: oc adm release new ... - ``` - -5. **Grant image pull access** for the sandbox namespace: - ```bash - oc policy add-role-to-group system:image-puller system:serviceaccounts:openshift-lightspeed -n cvo-dev - ``` - -6. **Apply the prompt ConfigMap**: - ```bash - oc apply -f install/0000_00_cluster-version-operator_50_lightspeed-prompts.yaml - ``` - -7. **Revert local changes** before committing (steps 1 and 3) \ No newline at end of file