I've found and fixed two bugs, and made a small tweak to EXTRAVERBOSE handling.
Would you prefer these as 3 separate pull requests, or 2 (one for the bug fixes and one for the enhancement)?
Bug: Year is missing from FILE line in cue, for cases where $YEAR is part of the OUTPUTFORMAT. (same w/ Genre)
Fix: add lines of code to create the $YEAR and $GENRE variables from the CDDB variables.
This is done in other sections of the code, but not in abcde.mkcue or do_cleancue.
Note: abcde.mkcue seems to have other issues as well - I'm using the default external mkcue
Bug: mkdir throws error & album art was not added if albumart_backup directory already existed. Broke all follow-on processes.
Fix : change all 'mkdir' into 'mkdir -p'
This is done in many other sections of the code, but not in do_embedalbumart.
Enhancement: EXTRAVERBOSE handling doesn't provide indicators of the logging level in output.
Fix: add '[verbose] ' to vecho and '[debug] ' to vvecho to help maintain situational awareness while reviewing logs.
I've found and fixed two bugs, and made a small tweak to EXTRAVERBOSE handling.
Would you prefer these as 3 separate pull requests, or 2 (one for the bug fixes and one for the enhancement)?
Bug: Year is missing from FILE line in cue, for cases where $YEAR is part of the OUTPUTFORMAT. (same w/ Genre)
Fix: add lines of code to create the $YEAR and $GENRE variables from the CDDB variables.
This is done in other sections of the code, but not in abcde.mkcue or do_cleancue.
Note: abcde.mkcue seems to have other issues as well - I'm using the default external mkcue
Bug: mkdir throws error & album art was not added if albumart_backup directory already existed. Broke all follow-on processes.
Fix : change all 'mkdir' into 'mkdir -p'
This is done in many other sections of the code, but not in do_embedalbumart.
Enhancement: EXTRAVERBOSE handling doesn't provide indicators of the logging level in output.
Fix: add '[verbose] ' to vecho and '[debug] ' to vvecho to help maintain situational awareness while reviewing logs.