Hi maintainers 馃憢
I prepared a minimal fix proposal for issue #5888 and would appreciate your review/feedback.
Problem statement
In the current behavior discussed in #5888, a manually-set Proxy-Authorization header may be removed too aggressively, including the initial request path in some flows.
Proposed behavior
- Preserve manually-set
Proxy-Authorization on the initial request path.
- Keep stripping behavior on redirect/proxy-change paths where rebuilding proxy auth is expected.
Implementation scope
I kept the patch intentionally small and focused:
requests/sessions.py
tests/test_5888_regression.py (new regression tests)
What tests cover
- initial non-redirect request preserves manually-set
Proxy-Authorization
- redirect/proxy-change path strips header as expected
- no regression in related auth/header interaction
Patch branch
I cannot open a direct PR due to repository permission restrictions, so I鈥檓 sharing the branch here:
If this direction looks good, I can adjust the patch immediately based on maintainer guidance.
Thanks!
Hi maintainers 馃憢
I prepared a minimal fix proposal for issue #5888 and would appreciate your review/feedback.
Problem statement
In the current behavior discussed in #5888, a manually-set
Proxy-Authorizationheader may be removed too aggressively, including the initial request path in some flows.Proposed behavior
Proxy-Authorizationon the initial request path.Implementation scope
I kept the patch intentionally small and focused:
requests/sessions.pytests/test_5888_regression.py(new regression tests)What tests cover
Proxy-AuthorizationPatch branch
I cannot open a direct PR due to repository permission restrictions, so I鈥檓 sharing the branch here:
aj-aura/requestsfix/proxy-auth-header-5888https://github.com/psf/requests/compare/main...aj-aura:requests:fix/proxy-auth-header-5888?expand=1
If this direction looks good, I can adjust the patch immediately based on maintainer guidance.
Thanks!