From a4ec45839ea35df20e5cdf1a21b449730f1e7426 Mon Sep 17 00:00:00 2001 From: Adriano Machado <60320+ammachado@users.noreply.github.com> Date: Sun, 6 Sep 2026 16:00:09 -0400 Subject: [PATCH] Add missing runtime dependencies to the pylint pre-commit hook The pylint hook was reporting import-error across the plugin modules. import-error is not in the disable= list in .pylintrc, and pre-commit runs each hook in its own isolated virtualenv, so the init-hook sys.path extension only ever sees the hook's own venv. Without these, pylint cannot resolve feedparser, koji, nitrate, bodhi-client and friends, and reports an error per plugin. This mirrors the list the mypy hook directly below already carries. The difference between the two is that pylint needs the real packages where mypy wants the stubs, hence requests and python-dateutil here instead of types-requests and types-python-dateutil. Co-Authored-By: Claude Opus 5 --- .pre-commit-config.yaml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index b656d1c72..30c634329 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -66,6 +66,23 @@ repos: "-sn", # Don't display the score "--rcfile=.pylintrc", # Link to config file ] + additional_dependencies: + [ + bodhi-client, + feedparser, + google-api-python-client, + gssapi, + koji, + nitrate, + oauth2client, + pytest, + python-bugzilla, + python-dateutil, + requests, + requests-gssapi, + setuptools, + tenacity, + ] - repo: https://github.com/codespell-project/codespell rev: v2.4.1