Skip to content

Stale comments claim 'this repo has released none' in three repos that now have frozen records #153

Description

@thedavidmeister

Three doc comments across the deploy repos claim their repo has released nothing under the frozen-record model. All three are now false — each repo has a frozen record and declared released suites, so the chain test has a subject and forks all seven networks.

Comments describe current behaviour only, so each of these is a comment that now misleads a reader about whether a test is inert.

  1. rain.deployscript/Deploy.sol:181-185: "RegistryDeployChainTest … only for RELEASED suites, and this repo has released none, so today it has nothing to check and passes." src/generated/0_1_7/ is frozen on main and LibAddressRegistryReleased declares address-registry@0_1_7. The same claim repeats at README.md:391-395.

  2. rain.math.float.deploytest/src/abstract/DecimalFloatDeployChain.t.sol: "This repo has cut no release under the frozen-record model yet, so releasedSuites() is empty and the inherited test has no subject and forks nothing." src/generated/0_1_1/{DecimalFloat,LogTables}.sol are frozen and LibDecimalFloatReleased/LibLogTablesReleased declare decimal-float@0_1_1 and log-tables@0_1_1.

  3. rain.factory.deployscript/Build.sol references "The frozen 0_1_3/0_1_4/0_1_5 snapshots"; the tree holds 0_1_9 and 0_1_10 only.

Filed against rain.deploy as the machinery owner; items 2 and 3 are in sibling repos and want their own small PRs there.

Found while deriving the current deploy-repo standard from these repos.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions