`testRequireContractNameErrorCarriesTheName` hand-rolls the `assertRejected` helper next to it

[thedavidmeister]

Audit scope: whole-repo, commit 7aa85a4

Dimension 4 (code quality) · low

Location: test/src/lib/LibCodeGen.requireContractName.t.sol:122-127

Path note: PR #56 is open and unmerged as of filing. On main today this file is test/lib/LibCodeGen.requireContractName.t.sol; it becomes test/src/lib/LibCodeGen.requireContractName.t.sol after #56 merges.

Problem

Lines 125-126 are exactly the body of assertRejected (lines 26-29), applied to
"sub/Foo" — a name testRequireContractNameRejectsPathCharacters:100 already
puts through that same helper. assertRejected already asserts selector and
name, so this test kills no mutant the helper does not.

Proposed fix

Delete it; the name-carrying claim belongs in the assertRejected
docstring, which is where the check actually lives.