Skip to content

Add frontend design and independent design-review skills to UI workflows #210

Description

@rochecompaan

Problem

Patchmill's recommended skill pack does not include dedicated frontend design guidance or a frontend design review. Visible UI work therefore relies on the generic specification, implementation, and code-review instructions. This can produce specifications without a concrete visual reference and can let visual or UX problems survive an otherwise successful code review.

Desired behavior

Keep the existing workflow:

  1. brainstorming writes the specification.
  2. writing-plans writes the implementation plan.
  3. The configured implementation workflow implements the plan.
  4. The normal code-review workflow runs.

Augment that workflow conditionally for visual frontend work. Do not introduce a separate design phase or replace the existing planning, implementation, or code-review skills.

Specification augmentation

When the proposed work requires user-visible frontend changes:

  • The specification author must use the configured frontend-design skill while writing the specification.
  • The specification work must include a runnable, responsive, full-page HTML mockup for the proposed UI.
  • The mockup must show changed components in page context rather than only as isolated fragments.
  • The specification must reference the mockup artifact.
  • The subsequent writing-plans step continues to operate normally, consuming the specification and its referenced mockup.

Use Anthropic's frontend-design as the upstream design guidance:

Wrap it with Patchmill-specific process for specification-time mockup creation and references. Existing project design systems and approved product requirements take precedence over generic aesthetic guidance.

Implementation and review augmentation

When the completed implementation includes user-visible frontend changes:

  • Complete the existing validation and normal code-review process first.
  • Then run an independent frontend design review using the configured frontend-review skill.
  • The frontend reviewer must report actionable findings and direct the implementation agent to fix them.
  • Repeat the frontend review after fixes as needed.
  • Rerun affected validation and normal code review when a frontend-review fix changes production code.
  • Preserve the existing visual-evidence behavior; use available visual evidence as review input rather than adding a new top-level workflow stage.

Base the review guidance on Vercel's Web Interface Guidelines:

Create a self-contained Patchmill wrapper. Do not retain the upstream skill's runtime WebFetch dependency or fetch mutable review rules. Project policy and the approved specification must override opinionated generic rules. Findings should include severity, user impact, evidence, and file:line where applicable.

Acceptance criteria

  • The recommended skill pack installs pinned frontend-design guidance and the applicable license/attribution files.
  • Patchmill provides a specification-time frontend-design wrapper that conditionally activates for user-visible frontend changes.
  • The wrapper requires a full-page HTML mockup and a reference to it from the specification.
  • The normal brainstorming and writing-plans workflow remains intact.
  • Patchmill provides a self-contained frontend-review skill based on pinned Vercel rules, with no mutable runtime fetch.
  • Frontend review runs independently and only after normal code review for implementations with user-visible frontend changes.
  • Frontend-review findings are routed to the implementation agent for fixes and can trigger a repeated review pass.
  • Existing validation, normal code review, and visual-evidence behavior remain intact.
  • Repository-specific design rules and the approved specification take precedence over generic skill opinions.
  • Skill-pack config, metadata, tests, and live dependency references resolve to the same pinned upstream versions.
  • Documentation explains the conditional behavior, mockup artifact, review order, and override precedence.

Notes

The frontend implementation skill and frontend-review skill are deliberately complementary. The former influences specification quality and provides a concrete visual artifact. The latter is an independent review pass and must not replace normal code review.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readyReady for automated agent processingplan-approvedImplementation plan approved for automationspec-approvedSpecification approved for automation

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions