`gba::sound::*::with_enabled()` might be a bit misleading name

[yutannihilation]

(Disclaimer: I'm yet to learn how to use these registers, so I might be wrong.)

The word "enabled" sounds like that it turns on and off the sound channel, but it seems what it does is re-triggering the sound.

For example,

• Tonc says "reset"
• GBATEK says "restart sound"

So, I'm wondering if some other word like "reset" fits better than "enabled".

[Lokathor]

yeah, this is true. I probably used enabled for consistency, but reset is probably a better term. or, if mgba calls this bit something else then maybe we could use that name, but i'm not at a computer with mgba installed right now.

[yutannihilation]

Thanks for the hint. In mGBA's code, it seems it's named as stop. No idea why this word was chosen...

https://github.com/mgba-emu/mgba/blob/cd3c21052e5f6f1a8126f18b47eacb0a783aa6ba/include/mgba/internal/gb/audio.h#L93