MSRV not tested?

[bjorn3]

#128 added a dependency on ar_archive_writer, which as noted in rust-lang/ar_archive_writer#28 breaks compilation with rustc < 1.88. PSM has an MSRV of 1.63 however.

[nagisa]

We do test it… to an extent. But I raised the version tested to 1.91 during the last release.

That said, my understanding of the rust-version annotation in the Cargo.toml is a little different than what you suggest. I don't believe it is the job of the crate to reflect the MSRV of all the dependencies as well. After all, if ar_archive_writer now releases a minor release that reduces its MSRV, then this crate, if it reflected the MSRVs of all dependencies at the time release, would still fail to compile.

Instead I've been largely treating rust-version as a description of the Rust requirement for the code specifically within the crate itself, nothing more, nothing less.

[nagisa]

Apparently psm does not specify any rust-version at all, only stacker does 👀 And stacker supports all the way back to psm 0.1.7 which should build just fine with 1.63.0.

[tisonkun]

I filed #149 to fix the MSRV requirement as is.

Feel free to drop a comment and see if we'd bump MSRV or fix it in place as #149 does.

[tisonkun]

This issue should now be resolved as we bump psm MSRV to 1.88 and introduce a CI workflow for regression.

I may review the CI workflows to see if there is any improvement can be done.

[tisonkun]

So here is #151.

But anyway this issue can be closed by #149.