From e3b4f0f7d0643d3f56ddf53b729963aded6890d5 Mon Sep 17 00:00:00 2001 From: chrism Date: Sat, 22 Aug 2026 16:45:57 -0400 Subject: [PATCH 1/5] Update tests to 1.88.0 to accommodate BLAS testing requirements --- .github/workflows/checking.yml | 2 +- .github/workflows/testing.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/checking.yml b/.github/workflows/checking.yml index 43c142156..faa6975d0 100644 --- a/.github/workflows/checking.yml +++ b/.github/workflows/checking.yml @@ -10,7 +10,7 @@ jobs: fail-fast: false matrix: toolchain: - - 1.87.0 + - 1.88.0 - stable - nightly os: diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 6892dbab3..6a8f3af1b 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -10,7 +10,7 @@ jobs: fail-fast: false matrix: toolchain: - - 1.87.0 + - 1.88.0 - stable os: - ubuntu-latest From c8eea4a95472ecd9d76f3ac6341d389de55f0f3b Mon Sep 17 00:00:00 2001 From: chrism Date: Sat, 22 Aug 2026 16:49:15 -0400 Subject: [PATCH 2/5] Update to 1.88.0 for both standard tests and BLAS --- .github/workflows/testing.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 6a8f3af1b..46eac8ab4 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -37,7 +37,7 @@ jobs: fail-fast: false matrix: toolchain: - - 1.87.0 + - 1.88.0 - stable os: - ubuntu-latest From fad83af57a839d288c81006b5f09696a3db2cef7 Mon Sep 17 00:00:00 2001 From: chrism Date: Sat, 22 Aug 2026 17:02:50 -0400 Subject: [PATCH 3/5] Remove unnecessary dataset lifetime to make clippy happy --- src/dataset/impl_dataset.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dataset/impl_dataset.rs b/src/dataset/impl_dataset.rs index 27cc9acff..b92a1dab1 100644 --- a/src/dataset/impl_dataset.rs +++ b/src/dataset/impl_dataset.rs @@ -1000,7 +1000,7 @@ where where ER: std::error::Error + std::convert::From, M: for<'c> Fit, ArrayView<'c, E, I>, ER, Object = O>, - O: for<'d> PredictInplace, Array>, + O: PredictInplace, Array>, FACC: Float, C: Fn( &Array, @@ -1061,7 +1061,7 @@ where where ER: std::error::Error + std::convert::From, M: for<'c> Fit, ArrayView1<'c, E>, ER, Object = O>, - O: for<'d> PredictInplace, Array1>, + O: PredictInplace, Array1>, FACC: Float, C: Fn(&Array1, &ArrayView1) -> std::result::Result, { From e0ab23873b01635d2420e079b502be2878ffec08 Mon Sep 17 00:00:00 2001 From: chrism Date: Sat, 22 Aug 2026 17:05:56 -0400 Subject: [PATCH 4/5] Apply clippy suggestion in linfa-lars re: late allocation --- algorithms/linfa-lars/src/algorithm.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/algorithms/linfa-lars/src/algorithm.rs b/algorithms/linfa-lars/src/algorithm.rs index 9088e5a73..91fa25af3 100644 --- a/algorithms/linfa-lars/src/algorithm.rs +++ b/algorithms/linfa-lars/src/algorithm.rs @@ -123,16 +123,16 @@ fn lars_path( } loop { - let c; + let mut c_idx = 0; let mut c_ = F::zero(); - if !cov.is_empty() { + let c = if !cov.is_empty() { c_idx = cov.abs().argmax().unwrap(); c_ = cov[c_idx]; - c = c_.abs(); + c_.abs() } else { - c = F::zero(); - } + F::zero() + }; let mut alpha = alphas.slice(s![n_iter, NewAxis]).to_owned(); let mut coef = coefs.row(n_iter).to_owned(); From f45977721381504c5f992531617f55bc96bc0c01 Mon Sep 17 00:00:00 2001 From: chrism Date: Sat, 22 Aug 2026 17:06:58 -0400 Subject: [PATCH 5/5] cargo fmt --- algorithms/linfa-lars/src/algorithm.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/algorithms/linfa-lars/src/algorithm.rs b/algorithms/linfa-lars/src/algorithm.rs index 91fa25af3..25254e90d 100644 --- a/algorithms/linfa-lars/src/algorithm.rs +++ b/algorithms/linfa-lars/src/algorithm.rs @@ -123,7 +123,6 @@ fn lars_path( } loop { - let mut c_idx = 0; let mut c_ = F::zero(); let c = if !cov.is_empty() {