Added clippy to CI and made minor code improvements - #576
Merged
Conversation
alejandro-vaz
self-requested a review
September 3, 2026 20:28
…strongly based on clippy warnings and standards)
pedrodesu
force-pushed
the
clippy-fixed-and-ci
branch
from
September 3, 2026 20:34
6ca44ef to
1c24955
Compare
Contributor
Author
|
I had messed up the base of this commit because of my other commit, so I just did a small rebase to remove the changes of the other PR from this diff. Should be good now. |
alejandro-vaz
approved these changes
Sep 3, 2026
Collaborator
|
sorry for the long delay, we are discussing what to do with the v2 architecture thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #566.
The accompanying code improvements are largely based on
clippystandards and then unsolvedclippyproblems in the project.