Skip to content

Image.propTypes is undefined when using ImagePreview component #795

Description

@cayleyh

PropTypes have been removed from React Native (react-native-community/discussions-and-proposals#29). Most of Shoutem has been updated to take this into account, but some areas have been missed.

For example, in ImagePreview, line 87 exports a source propType for the component like so:

source: Image.propTypes.source

Which of course fails with a TypeError: Cannot read properties of undefined (reading 'source') error. The Shoutem Image component has been updated to use ImagePropTypes from the deprecated-react-native-prop-types package, avoiding these issues.

There are 2 potential solutions:

  1. Update ImagePreview to use the Shoutem Image component instead of the react-native component.
  2. Update ImagePreview to use ImagePropTypes from deprecated-react-native-prop-types

What is the preferred solution for the shoutem team here?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions