From 67e56f040c18dff65fc0eb34cd2fea9d75fddfba Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Wed, 5 Aug 2026 09:48:49 -0400 Subject: [PATCH 1/3] [BUGFIX] sonarcloud: tainted value 'this' is leaking. https://sonarcloud.io/project/issues?open=AZ9fG2eVvKN1Zd_3Vb33&id=sir-gon_algorithm-exercises-cpp --- .../exercises/src/hackerrank/warmup/time_conversion.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/lib/exercises/src/hackerrank/warmup/time_conversion.cpp b/src/lib/exercises/src/hackerrank/warmup/time_conversion.cpp index 09f6fef..797cb9a 100644 --- a/src/lib/exercises/src/hackerrank/warmup/time_conversion.cpp +++ b/src/lib/exercises/src/hackerrank/warmup/time_conversion.cpp @@ -35,11 +35,7 @@ std::string timeConversion(const std::string &s) { time.push_back(segment); } - std::stringstream hour_str; - hour_str << time[0]; - - int hour; - hour_str >> hour; + int hour = std::stoi(time[0]); if (hour < 0 || hour > 23) { throw std::invalid_argument("Invalid hour value: " + std::to_string(hour)); @@ -53,6 +49,8 @@ std::string timeConversion(const std::string &s) { hour += 12; } + std::stringstream hour_str; + hour_str.str(""); hour_str.clear(); From a978176b9eebf07567815792010e25be20710811 Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Wed, 5 Aug 2026 11:13:17 -0400 Subject: [PATCH 2/3] [CONFIG] baseline introduced to vcpkg --- vcpkg.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vcpkg.json b/vcpkg.json index 666a13b..57523d4 100644 --- a/vcpkg.json +++ b/vcpkg.json @@ -2,5 +2,6 @@ "dependencies": [ "catch2", "nlohmann-json" - ] + ], + "builtin-baseline": "dd3097e305afa53f7b4312371f62058d2e665320" } From db28067fe54e2a44336af157689924b3931ead2f Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Wed, 5 Aug 2026 11:13:17 -0400 Subject: [PATCH 3/3] [Github Actions] MacOS workflow now use updated version of vcpkg. --- .github/workflows/cpp-macos.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpp-macos.yml b/.github/workflows/cpp-macos.yml index 4062d45..701b4df 100644 --- a/.github/workflows/cpp-macos.yml +++ b/.github/workflows/cpp-macos.yml @@ -9,6 +9,9 @@ on: # yamllint disable-line rule:truthy branches: ["main"] workflow_dispatch: +env: + VCPKG_VERSION: 2026.07.29 + jobs: test: name: C/C++ CMake CI Test @@ -29,9 +32,8 @@ jobs: - name: Install shell: bash run: | - export VCPKG_VERSION=2025.02.14 + export VCPKG_VERSION=${VCPKG_VERSION} git clone \ - --depth 1 \ --branch $VCPKG_VERSION \ https://github.com/microsoft/vcpkg.git \ --single-branch \