You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copilot was unable to run its full agentic suite in this review.
This PR improves SimpleFileDialog open-validation by allowing folder creation prompts when the selected folder doesn’t exist but a writable ancestor does, and adds a browser test to validate nested folder creation behavior.
Changes:
Update open-dialog validation to allow creating missing nested folders when an ancestor directory is writable.
Add canCreateFolder() helper to determine whether folder creation is possible by walking up the URI.
Add a new browser test covering nested folder creation from a folder-only open dialog.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves
SimpleFileDialogopen-validation by allowing folder creation prompts when the selected folder doesn’t exist but a writable ancestor does, and adds a browser test to validate nested folder creation behavior.Changes:
canCreateFolder()helper to determine whether folder creation is possible by walking up the URI.Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
canCreateFolder) and uses it to decide whether to prompt for folder creation.Originally posted by @copilot-pull-request-reviewer in microsoft/vscode#321355 (review)