Skip to content

## Pull request overview #170

Description

@ilimtvtr-alt

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR improves SimpleFileDialog open-validation by allowing folder creation prompts when the selected folder doesn’t exist but a writable ancestor does, and adds a browser test to validate nested folder creation behavior.

Changes:

  • Update open-dialog validation to allow creating missing nested folders when an ancestor directory is writable.
  • Add canCreateFolder() helper to determine whether folder creation is possible by walking up the URI.
  • Add a new browser test covering nested folder creation from a folder-only open dialog.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/vs/workbench/services/dialogs/test/browser/simpleFileDialog.test.ts Adds coverage for creating nested missing folders via the open dialog validation path.
src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts Introduces ancestor-writability check (canCreateFolder) and uses it to decide whether to prompt for folder creation.

Originally posted by @copilot-pull-request-reviewer in microsoft/vscode#321355 (review)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions