Skip to content

[audit] obsidian.nvim and quicker.nvim setup blocks skip the is_vscode guard every other plugin uses #326

Description

@stanfish06

What

lua/config/plugin_config.lua gates 16+ plugin setup blocks behind not is_vscode (fzf-lua, blink.cmp, conform, nvim-lint, diffview, gitsigns, tiny-inline-diagnostic, refactoring, treesitter-textobjects, render-markdown, snacks, noice, etc. — see grep -n is_vscode lua/config/plugin_config.lua). The obsidian.nvim block and the quicker.nvim block do not follow this pattern and run unconditionally whenever the respective pcall(require, ...) succeeds.

Where

  • lua/config/plugin_config.lua:352-353 (obsidian_ok check has no and not is_vscode)
  • lua/config/plugin_config.lua:380-381 (quicker_ok check has no and not is_vscode)

Why it matters

The obsidian.setup() call has a real filesystem side effect regardless of vim.g.vscode: it runs vim.fn.mkdir(notes_path, "p") (line 357) and registers workspace/command state. If this config is ever loaded under vim.g.vscode (VSCode Neovim extension), obsidian and quicker would be the two plugins that still fully initialize while everything else around them is suppressed — likely unintentional given how consistently the is_vscode guard is applied elsewhere in this same file.

That said, obsidian.nvim's own config already sets ui = { enable = false }, which could be read as a deliberate partial vscode-awareness rather than an oversight — hence filing this as an issue for a judgment call rather than assuming intent and pushing a mechanical PR.

Recommended action

Either add and not is_vscode to both if obsidian_ok then and if quicker_ok then for consistency with the rest of the file, or, if the omission is intentional (e.g. obsidian note-taking should still work inside VSCode), leave a comment explaining why these two are exceptions so future audits don't re-flag it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions