Hi, thanks for the work on this gem.
I noticed the current code doesn't handle errors at all, so a bad response would result in trying to parse invalid JSON.
I'm mostly making this issue to work out how errors should be handled.
An easy solution could be simply returning nil for WeatherResponse.weather when !response.success?
But it's possible we could want to provide more info in the regular response, without the user having to look at the raw response.
Hi, thanks for the work on this gem.
I noticed the current code doesn't handle errors at all, so a bad response would result in trying to parse invalid JSON.
I'm mostly making this issue to work out how errors should be handled.
An easy solution could be simply returning
nilforWeatherResponse.weatherwhen!response.success?But it's possible we could want to provide more info in the regular response, without the user having to look at the raw response.