From a8271ceaca72fbb0aa066b05ad1a33924a064d73 Mon Sep 17 00:00:00 2001 From: preslavmihaylov Date: Mon, 7 Sep 2026 09:46:46 +0300 Subject: [PATCH] ORCA-903: regenerate @team-plain/graphql after isSuccess removal --- .changeset/orca-903-drop-issuccess-from-schema.md | 9 +++++++++ packages/graphql/src/_generated_documents.ts | 6 ------ packages/graphql/src/schema.graphql | 6 ------ 3 files changed, 9 insertions(+), 12 deletions(-) create mode 100644 .changeset/orca-903-drop-issuccess-from-schema.md diff --git a/.changeset/orca-903-drop-issuccess-from-schema.md b/.changeset/orca-903-drop-issuccess-from-schema.md new file mode 100644 index 0000000..5909b86 --- /dev/null +++ b/.changeset/orca-903-drop-issuccess-from-schema.md @@ -0,0 +1,9 @@ +--- +"@team-plain/graphql": minor +--- + +Regenerate against the current API schema. The API removed the deprecated `isSuccess` field from `ThreadDiscussionToolCallEntryPayload`, so it is gone from the bundled schema and from the exported type of the same name. + +**Nothing a caller reads off a response changes, and this is not a second break.** 3.0.0 already stopped selecting `isSuccess`, which removed it from the generated result types and shipped as a major. What is left to remove here is the last two traces: the bundled schema copy and the field on the exported `ThreadDiscussionToolCallEntryPayload` type. No document selected it, so no result type changes. + +That exported type is still public API, so code naming `ThreadDiscussionToolCallEntryPayload['isSuccess']` stops compiling with TS2339. Read `status` instead, a `DiscussionToolCallStatus` of `PENDING`, `SUCCESS` or `ERROR`. Do not translate the old boolean as `status === 'SUCCESS'` and stop: `false` covered a call that was still running as well as one that failed, so code treating every `false` as a failure was already mislabelling pending calls. diff --git a/packages/graphql/src/_generated_documents.ts b/packages/graphql/src/_generated_documents.ts index b21db1d..e778dd1 100644 --- a/packages/graphql/src/_generated_documents.ts +++ b/packages/graphql/src/_generated_documents.ts @@ -14602,12 +14602,6 @@ export type ThreadDiscussionToolCallEntryPayload = { description: Scalars['String']['output']; durationMs: Scalars['Int']['output']; error?: Maybe; - /** - * True only when the call succeeded. A call still PENDING also reads false, so this - * boolean can no longer tell "not finished" from "failed". Use status for that. - * @deprecated Use status, which separates PENDING from ERROR. - */ - isSuccess: Scalars['Boolean']['output']; op?: Maybe; /** Null on a call an agent reported: Plain has no name for it. */ service?: Maybe; diff --git a/packages/graphql/src/schema.graphql b/packages/graphql/src/schema.graphql index 8b6106a..7dafd7f 100644 --- a/packages/graphql/src/schema.graphql +++ b/packages/graphql/src/schema.graphql @@ -1111,12 +1111,6 @@ type ThreadDiscussionToolCallEntryPayload { """Where the call is in its lifecycle.""" status: DiscussionToolCallStatus! - - """ - True only when the call succeeded. A call still PENDING also reads false, so this - boolean can no longer tell "not finished" from "failed". Use status for that. - """ - isSuccess: Boolean! @deprecated(reason: "Use status, which separates PENDING from ERROR.") error: String durationMs: Int! }