diff --git a/AGENTS.md b/AGENTS.md index 0366cb3..6c3d454 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -41,3 +41,6 @@ Redux, SwiftUI, and application-localization guidance do not apply to the packag - Preserve compiler-synthesized value semantics and serialization when evolving public models. - Update tests, DocC, README examples, and release notes when public behavior changes. - Use logging subsystem `com.thatfactory.progressionkit`, category `progression`, and canonical package emoji `📈`. +## Codex review scope + +For consumer pull requests, do not substantively review `AgentGuidelines/**` after exact tagged-tree provenance has been verified. Verify its `VERSION`, compare its tree with the matching central tag, and verify the required `.gitattributes` rule. If provenance does not match exactly, review the subtree contents and stop the merge. Report substantive guideline feedback against the central `agent-guidelines` pull request. diff --git a/AgentGuidelines/AGENTS.md b/AgentGuidelines/AGENTS.md index f3cc3d6..7c39de6 100644 --- a/AgentGuidelines/AGENTS.md +++ b/AgentGuidelines/AGENTS.md @@ -46,6 +46,10 @@ python3 Scripts/validate_guidelines.py Fix every validation failure before releasing a version. +## Consumer pull-request review scope + +When reviewing a consumer pull request, do not review or comment on files under `AgentGuidelines/**` after exact tagged-tree provenance has been verified. That subtree is a tracked, synchronized copy marked `linguist-generated`; substantive guideline changes are reviewed in this repository. Verify the intended `AgentGuidelines/VERSION`, compare the subtree tree with the matching central tag (for example with `git subtree split --prefix=AgentGuidelines HEAD` and a tree comparison after fetching that tag), and verify the required `.gitattributes` rule. If provenance does not match exactly, review the subtree contents and stop the merge. Report substantive guideline feedback against the central `agent-guidelines` pull request instead. + ## Releases - Use semantic versioning. diff --git a/AgentGuidelines/CHANGELOG.md b/AgentGuidelines/CHANGELOG.md index a190b2d..995b21d 100644 --- a/AgentGuidelines/CHANGELOG.md +++ b/AgentGuidelines/CHANGELOG.md @@ -2,6 +2,12 @@ All notable changes to this project are documented in this file. +## [0.0.9] - 2026-07-23 + +### Added + +- Consumer pull-request review scope that excludes synchronized `AgentGuidelines/**` files from substantive Codex and human review outside the central repository. + ## [0.0.8] - 2026-07-23 ### Added diff --git a/AgentGuidelines/Guidelines/GitHub/PullRequests.md b/AgentGuidelines/Guidelines/GitHub/PullRequests.md index 899666f..3535d36 100644 --- a/AgentGuidelines/Guidelines/GitHub/PullRequests.md +++ b/AgentGuidelines/Guidelines/GitHub/PullRequests.md @@ -9,6 +9,10 @@ Use this guide whenever creating, reviewing, updating, or merging a GitHub pull - Run the relevant local validation and document anything that could not be run. - Open the pull request without auto-merge and keep it unmerged while automated or agent review is pending. Use draft state only when configured reviewers also run on drafts. +## Consumer subtree review scope + +When reviewing a consumer pull request, do not review or comment on files under `AgentGuidelines/**` after exact tagged-tree provenance has been verified. The subtree is a tracked, synchronized copy marked `linguist-generated`; substantive guideline changes are reviewed in the central `thatfactory/agent-guidelines` pull request. Verify `AgentGuidelines/VERSION`, compare the subtree tree with the matching central tag (for example with `git subtree split --prefix=AgentGuidelines HEAD` and a tree comparison after fetching that tag), and verify the required `.gitattributes` rule. If provenance does not match exactly, review the subtree contents and stop the merge. Report substantive guideline feedback against the central pull request instead. + ## Review gate Opening a pull request starts review; it does not authorize merging it. diff --git a/AgentGuidelines/README.md b/AgentGuidelines/README.md index c40ea35..7a801a1 100644 --- a/AgentGuidelines/README.md +++ b/AgentGuidelines/README.md @@ -85,7 +85,7 @@ From the consumer repository root, install a tagged release: git subtree add \ --prefix=AgentGuidelines \ https://github.com/thatfactory/agent-guidelines.git \ - 0.0.8 \ + 0.0.9 \ --squash ``` @@ -106,7 +106,7 @@ Review the target release's changelog, then pull it deliberately: git subtree pull \ --prefix=AgentGuidelines \ https://github.com/thatfactory/agent-guidelines.git \ - 0.0.8 \ + 0.0.9 \ --squash ``` diff --git a/AgentGuidelines/Templates/AGENTS.md b/AgentGuidelines/Templates/AGENTS.md index 66d89dd..4bad2bd 100644 --- a/AgentGuidelines/Templates/AGENTS.md +++ b/AgentGuidelines/Templates/AGENTS.md @@ -25,6 +25,16 @@ Read only the guides relevant to the task: For an application that uses Redux, also read [Redux architecture](AgentGuidelines/Guidelines/Architecture/Redux.md). +Add the following section to the consumer repository's root `AGENTS.md` so it is loaded for root-level Codex and pull-request work: + +```md +## Codex review scope + +For consumer pull requests, do not substantively review `AgentGuidelines/**` after exact tagged-tree provenance has been verified. Verify its `VERSION`, compare its tree with the matching central tag, and verify the required `.gitattributes` rule. If provenance does not match exactly, review the subtree contents and stop the merge. Report substantive guideline feedback against the central `agent-guidelines` pull request. +``` + +This tracked, synchronized subtree is reviewed centrally in `thatfactory/agent-guidelines`; the root-level instruction ensures the review scope is loaded even when Codex starts from the repository root. + ## Physical folder map Replace these examples with exact repository paths: diff --git a/AgentGuidelines/VERSION b/AgentGuidelines/VERSION index d169b2f..c5d54ec 100644 --- a/AgentGuidelines/VERSION +++ b/AgentGuidelines/VERSION @@ -1 +1 @@ -0.0.8 +0.0.9