From 4fdfe37f45b0499f874fa852653b44e7bbdd545b Mon Sep 17 00:00:00 2001 From: Fabian Hirmann <117293434+fabianhirmann@users.noreply.github.com> Date: Wed, 22 Jul 2026 09:41:43 +0200 Subject: [PATCH 1/2] node_interfaces.hpp: add missing include of stdexcept (#3210) Signed-off-by: Fabian Hirmann --- rclcpp/include/rclcpp/node_interfaces/node_interfaces.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/rclcpp/include/rclcpp/node_interfaces/node_interfaces.hpp b/rclcpp/include/rclcpp/node_interfaces/node_interfaces.hpp index 1845e84dcb..7668e92779 100644 --- a/rclcpp/include/rclcpp/node_interfaces/node_interfaces.hpp +++ b/rclcpp/include/rclcpp/node_interfaces/node_interfaces.hpp @@ -16,6 +16,7 @@ #define RCLCPP__NODE_INTERFACES__NODE_INTERFACES_HPP_ #include +#include #include "rclcpp/detail/template_unique.hpp" #include "rclcpp/node_interfaces/detail/node_interfaces_helpers.hpp" From a8d65c134fb5c2128670945b8dc7a9e62b25776c Mon Sep 17 00:00:00 2001 From: Guilhem Saurel Date: Thu, 23 Jul 2026 18:29:08 +0200 Subject: [PATCH 2/2] add missing header for std::function (#3211) fix play_motion2 on nix: ```cpp [ 60%] Built target ament_cmake_python_build_play_motion2_egg In file included from /build/play_motion2-release-release-humble-play_motion2-1.8.5-1/src/utils/motion_loader.hpp:23, from /build/play_motion2-release-release-humble-play_motion2-1.8.5-1/src/utils/motion_loader.cpp:19: /nix/store/ifw8313yfmyarrgqscg249m9krx58sh2-ros-humble-rclcpp-16.0.19-r1/include/rclcpp/rclcpp/node_interfaces/node_parameters_interface.hpp:42:10: error: 'function' in namespace 'std' does not name a template type 42 | std::function< | ^~~~~~~~ /nix/store/ifw8313yfmyarrgqscg249m9krx58sh2-ros-humble-rclcpp-16.0.19-r1/include/rclcpp/rclcpp/node_interfaces/node_parameters_interface.hpp:30:1: note: 'std::function' is defined in header ''; this is probably fixable by adding '#include ' 29 | #include "rclcpp/parameter.hpp" +++ |+#include 30 | #include "rclcpp/visibility_control.hpp" ``` already fixed in rolling: #2018 Signed-off-by: Guilhem Saurel --- .../include/rclcpp/node_interfaces/node_parameters_interface.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/rclcpp/include/rclcpp/node_interfaces/node_parameters_interface.hpp b/rclcpp/include/rclcpp/node_interfaces/node_parameters_interface.hpp index 729a006b26..08a693f8f7 100644 --- a/rclcpp/include/rclcpp/node_interfaces/node_parameters_interface.hpp +++ b/rclcpp/include/rclcpp/node_interfaces/node_parameters_interface.hpp @@ -15,6 +15,7 @@ #ifndef RCLCPP__NODE_INTERFACES__NODE_PARAMETERS_INTERFACE_HPP_ #define RCLCPP__NODE_INTERFACES__NODE_PARAMETERS_INTERFACE_HPP_ +#include #include #include #include