Skip to content

Commit da7ebab

Browse files
committed
test(core): pin the unallocated version char to 9 so gen-3 does not break it
1 parent 70a3df0 commit da7ebab

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/core/src/v3/isomorphic/friendlyId.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ describe("parseRunId — version-char discrimination (not length)", () => {
181181

182182
it("falls back to legacy on a malformed v1 (bad alphabet / wrong version char)", () => {
183183
expect(parseRunId(`run_${"A".repeat(25)}1`).format).toBe("legacy"); // uppercase core
184-
expect(parseRunId(`run_${"a".repeat(25)}3`).format).toBe("legacy"); // unknown version
184+
expect(parseRunId(`run_${"a".repeat(25)}9`).format).toBe("legacy"); // unallocated version
185185
expect(parseRunId(`run_${"a".repeat(25)}2`).format).toBe("b32hexV2"); // "2" is now gen-2
186186
expect(parseRunId(`run_${"a".repeat(24)}-1`).format).toBe("legacy"); // region char not [a-z0-9]
187187
expect(parseRunId(`run_${"a".repeat(27)}`).format).toBe("legacy"); // old 27-char shape

packages/core/src/v3/isomorphic/runOpsResidency.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ describe("ownerEngine — residency classifier (version char at fixed position,
4646
const v1 = "a".repeat(24) + "e1";
4747
expect(ownerEngine(v1)).toBe("NEW");
4848
expect(ownerEngine("a".repeat(24) + "e2")).toBe("NEW"); // gen-2: shard "e"
49-
expect(ownerEngine("a".repeat(24) + "e3")).toBe("LEGACY"); // unknown version char
49+
expect(ownerEngine("a".repeat(24) + "e9")).toBe("LEGACY"); // unallocated version char
5050
expect(ownerEngine("a".repeat(26))).toBe("LEGACY"); // 26 chars but no version marker
5151
});
5252

@@ -110,7 +110,7 @@ describe("resolveShard — the gen-2 refinement inside the dedicated family", ()
110110
"a".repeat(24) + "-1", // hyphen positional char
111111
"a".repeat(24) + "-2", // hyphen positional char, gen-2 version
112112
"a".repeat(26), // 26 chars, no version marker
113-
"a".repeat(24) + "e3", // unknown version char
113+
"a".repeat(24) + "e9", // unallocated version char
114114
"x".repeat(40),
115115
]) {
116116
expect(resolveShard(bad)).toBe("legacy");

0 commit comments

Comments
 (0)