Built in ticket management - #693
Conversation
|
This PR adds full support for ticket management both admin-ui and engine side. new mutations added
New queries
new resolver access control permissions
Message templates
Admin-ui has Two-mode access in which Admins skip passcode (see all events), anonymous users authenticate via passcode (see only their events) |
2ceb5a2 to
88ed454
Compare
There was a problem hiding this comment.
i don't know, i think the event scanner pass code feature should be left out of this pr in general for a first version, it's fine if it works with properly logged in users with corect permissions in the beginning.
88ed454 to
7ddcee3
Compare
7ddcee3 to
4d3fdf1
Compare
|
All mutations and queries that are ticket specific have to live in the ticketing package, this extension can't be part of the normal api, it's too specific. |
pozylon
left a comment
There was a problem hiding this comment.
See my other comment about package
0406fe1 to
6764852
Compare
|
@Mikearaya check the diffs, it's not clean yet, setHeader and getHeader that kind of helpers is fine in api but isCanceled is ticketing specific |
9760678 to
74218da
Compare
|
@pozylon i've moved all the remaining ticketing-specific resolvers into ticketing packages now |
74218da to
986d457
Compare
|
Now admin-ui needs to somehow determine if the ticketing module is loaded on the engine before showing the gate control feature and ticketing. i am trying to figure out the best way to do this |
|
@Mikearaya can't you just check for permissions? ticketing has additional acl, right? and that's in User.allowedActions. admin-ui components don't have to be in the ticketing extensions |
|
I think that all ticket management related features should stay in one main menu point in admin-ui, so don't mix in the ticketing stuff in the normal products/user etc. |
|
what is important is that if a user has the scan ticket permission, he/she should have the scanner in the admin-ui so we don't have to build a scan page for every ticketing customer |
|
@pozylon The issue with
What I’ve been thinking about and working on is moving the relevant components into the ticketing module itself. These components could then be imported by any project that uses ticketing and injected through the new Admin UI plugin system. This approach would allow us to keep the ticketing-specific code within the ticketing module and prevent |
|
@Mikearaya yes it's a perfect case to battle-test your admin ui plugin system |
eeeb3c0 to
bf19ab6
Compare
|
@Mikearaya i merged the ESM plugin PR, please check this PR here |
pozylon
left a comment
There was a problem hiding this comment.
rebase and build upon the new esm plugin system
… access control implementation
bf19ab6 to
a2fb8db
Compare
|
@pozylon Rebase, tested and fixed. everything is in place now |
No description provided.