From 6d60bcb2a64f8595391da850de7458b58f212766 Mon Sep 17 00:00:00 2001
From: Ryanmello07 <67509637+Ryanmello07@users.noreply.github.com>
Date: Tue, 8 Sep 2026 18:32:43 -0700
Subject: [PATCH] Emit the app catalog's connector symbol at SF Symbols 6 too

CI has been red on main since 2026-09-03. Every run fails in the same
place, before any artwork is read:

    error: Template format 7.0 is newer than the version that this
    software supports (6.0)
    app/network/Assets.xcassets:./ur.symbols.connector.fill.symbolset:
    The SVG file provided for the symbol image set is not suitable

The build dies there, so three steps never run at all: the extension size
budget, the whole macOS leg of a check named "iOS + macOS", and the unit
tests. Inside the iOS step the app target is never compiled either -- its
Swift task is scheduled and cancelled milliseconds later -- so main has
had no compile coverage of the app, and no test coverage at all, for six
days and roughly 25k lines.

This is a regression of a fix that already landed. #338 downgraded the
symbols to Template v.6.0 and added gen_connector_symbols.py, whose
docstring states the constraint: CI pins Xcode 16.4 and its actool
rejects a newer template outright. That fix generated only the widgets
catalog. A later SF Symbols 7 export landed a fresh copy of the same
symbol in app/network, which nothing here owned, so the constraint
silently did not apply to it.

Regenerate that copy from the same script. The diff is the version stamp
and the SF Symbols 7 style attributes -- motion groups and layer tags,
which the pinned toolchain cannot read anyway; not one path element
changes. Verified by generating into a temp directory and diffing: the
script reproduces the committed widgets catalog byte for byte, so its
output is exactly what has been building in CI all along.

Also record in the docstring that TWO catalogs carry these symbols and
that both are subject to the 6.0 rule, with the commands for each.
Generating only one of them is precisely how the constraint was lost.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AWV4MaF9JBcQppSX9UxATa
---
 .../ur.symbols.connector.fill.svg                  | 12 +++++-------
 .../Assets.xcassets/gen_connector_symbols.py       | 14 ++++++++++++++
 2 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/app/network/Assets.xcassets/ur.symbols.connector.fill.symbolset/ur.symbols.connector.fill.svg b/app/network/Assets.xcassets/ur.symbols.connector.fill.symbolset/ur.symbols.connector.fill.svg
index 4bd634fc..27d74b76 100644
--- a/app/network/Assets.xcassets/ur.symbols.connector.fill.symbolset/ur.symbols.connector.fill.svg
+++ b/app/network/Assets.xcassets/ur.symbols.connector.fill.symbolset/ur.symbols.connector.fill.svg
@@ -4,13 +4,11 @@ PUBLIC "-//W3C//DTD SVG 1.1//EN"
        "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
 <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 3300 2200">
  <!--URnetwork connector mark, generated by gen_symbols.py from QuickOn.svg-->
- <style>.defaults {-sfsymbols-variable-value-mode:color;-sfsymbols-draw-reverses-motion-groups:true}
+ <style>.monochrome-0 {}
 
-.monochrome-0 {-sfsymbols-motion-group:0;-sfsymbols-layer-tags:564789760d3a318d}
+.multicolor-0:tintColor {}
 
-.multicolor-0:tintColor {-sfsymbols-motion-group:0;-sfsymbols-layer-tags:564789760d3a318d}
-
-.hierarchical-0:primary {-sfsymbols-motion-group:0;-sfsymbols-layer-tags:564789760d3a318d}
+.hierarchical-0:primary {}
 
 .SFSymbolsPreviewWireframe {fill:none;opacity:1.0;stroke:black;stroke-width:0.5}
 </style>
@@ -20,8 +18,8 @@ PUBLIC "-//W3C//DTD SVG 1.1//EN"
   <text style="stroke:none;fill:black;font-family:sans-serif;font-size:13;text-anchor:middle;" transform="matrix(1 0 0 1 559.711 322)">Ultralight</text>
   <text style="stroke:none;fill:black;font-family:sans-serif;font-size:13;text-anchor:middle;" transform="matrix(1 0 0 1 1449.84 322)">Regular</text>
   <text style="stroke:none;fill:black;font-family:sans-serif;font-size:13;text-anchor:middle;" transform="matrix(1 0 0 1 2933.4 322)">Black</text>
-  <text id="template-version" style="stroke:none;fill:black;font-family:sans-serif;font-size:13;text-anchor:end;" transform="matrix(1 0 0 1 3036 1933)">Template v.7.0</text>
-  <text style="stroke:none;fill:black;font-family:sans-serif;font-size:13;text-anchor:end;" transform="matrix(1 0 0 1 3036 1951)">Requires Xcode 26 or greater</text>
+  <text id="template-version" style="stroke:none;fill:black;font-family:sans-serif;font-size:13;text-anchor:end;" transform="matrix(1 0 0 1 3036 1933)">Template v.6.0</text>
+  <text style="stroke:none;fill:black;font-family:sans-serif;font-size:13;text-anchor:end;" transform="matrix(1 0 0 1 3036 1951)">Requires Xcode 16 or greater</text>
   <text id="descriptive-name" style="stroke:none;fill:black;font-family:sans-serif;font-size:13;text-anchor:end;" transform="matrix(1 0 0 1 3036 1969)">Generated from ur.symbols.connector.fill</text>
   <text style="stroke:none;fill:black;font-family:sans-serif;font-size:13;text-anchor:end;" transform="matrix(1 0 0 1 3036 1987)">Typeset at 100.0 points</text>
   <text style="stroke:none;fill:black;font-family:sans-serif;font-size:13;" transform="matrix(1 0 0 1 263 726)">Small</text>
diff --git a/app/widgets/Assets.xcassets/gen_connector_symbols.py b/app/widgets/Assets.xcassets/gen_connector_symbols.py
index 684d0f11..7caeb4c5 100644
--- a/app/widgets/Assets.xcassets/gen_connector_symbols.py
+++ b/app/widgets/Assets.xcassets/gen_connector_symbols.py
@@ -19,6 +19,20 @@
 this software supports (6.0)" -- before it reads any of the artwork. The SF
 Symbols app on a current machine exports 7.0, so if you re-export from it,
 re-apply the 6.0 changes here rather than committing its output.
+
+TWO CATALOGS carry these symbols and both are subject to that rule:
+
+    app/widgets/Assets.xcassets   both symbols
+    app/network/Assets.xcassets   ur.symbols.connector.fill only
+
+Generating only the widgets catalog is how the 6.0 constraint was lost once
+already: a later SF Symbols 7 export landed in app/network and broke every
+build for a week, because nothing here owned that copy. Regenerate BOTH:
+
+    python3 gen_connector_symbols.py app/widgets/Assets.xcassets
+    python3 gen_connector_symbols.py /tmp/gen && \
+        cp /tmp/gen/ur.symbols.connector.fill.symbolset/* \
+           app/network/Assets.xcassets/ur.symbols.connector.fill.symbolset/
 """
 import math
 import os